Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the ccdhmodel python code into PyPI as a package #69

Closed
turbomam opened this issue Jul 28, 2021 · 3 comments · Fixed by #122
Closed

Get the ccdhmodel python code into PyPI as a package #69

turbomam opened this issue Jul 28, 2021 · 3 comments · Fixed by #122
Assignees

Comments

@turbomam
Copy link
Member

Possibly by taking advantage of the new linkml/linkml-model-template

It shouldn't be necessary to manually copy ccdhmodel.py and ccdhmodel.yaml into cancerDHC/example-data

From @gaurav:
The main things we want from the new template are:

  • standardization: the goal is that any other LinkML user should be able to look at our repository and figure out pretty quickly where the artifact they want is located, or how to modify the schema -> artifact build process.
  • pick up @hsolbrig's publish-to-pypi code, so that the generated Python module can be published to PyPi.
@gaurav
Copy link
Collaborator

gaurav commented Oct 13, 2021

I think cancerDHC/example-data#22 shows that the crdch-model package in PyPI is working correctly. I'll close this issue for now; please feel free to reopen it or open a new issue if the crdch-model package isn't working correctly for any reason.

@gaurav gaurav closed this as completed Oct 13, 2021
@gaurav
Copy link
Collaborator

gaurav commented Oct 13, 2021

Ah, now I remember, this is open until PR #122 is merged. Reopening.

@gaurav gaurav reopened this Oct 13, 2021
@turbomam
Copy link
Member Author

Ah, now I remember, this is open until PR #122 is merged. Reopening.

I approved #122 but didn't merge in case @sujaypatil96 wanted to weigh in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants