-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CCDH Pilot examples #22
Conversation
Because of unrelated bugs.
2ae7f21
to
c497f4e
Compare
I did I get the following warning, as I do in some other LinkML base projects.
|
Is there any documentation about where the YAMl data files in |
@gaurav , when you say that some of the Pilot Demonstrators "don't work", do you mean that they don't validate on ingestions, or that they couldn't be created programmatically right now because of the decimal types incompatibility? I'll be trying to answer this question for myself and possibly writing a test now. |
Sorry, I should have been clearer! The YAML files included in this PR all "work" in that they pass validation, but I had to comment out some lines that either don't pass validation or that couldn't be loaded using the Python Data Classes. I think this is almost entirely because of cancerDHC/ccdhmodel#154, so I don't know that new tests are necessary. I have a list of all non-validating fields: #39 |
Adds the CCDH Pilots to the Example Data Repository. Some of these don't work, probably because of bugs in LinkML Runtime (#39). Others either can't be set up with the Python Data Classes or cannot be validated when they are (#40).
Changes requested:
Should be merged after PR #41