-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PyPI package generation #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujaypatil96 and I were playing around with packages = find: b ut this is better.
We definitely need to add |
Okay, I think I've added @turbomam I haven't been able to figure out how to get setup.cfg to include crdch_model as the top-level object (i.e. you would still need Another option would be to rename the file from I'd love to know your thoughts, and if we need more time, we can discuss this on the Thursday call. |
@turbomam Oh, I should have mentioned:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can access BodySite() after importing 1.1.2, 1.1.3 or 1.1.5 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think I figured out what's causing the problem:
package_dir=
=crdch_model
packages=find:
[options.packages.find]
where=crdch_model
By adding the above snippet, we can import crdch_model
in the same way as PR #127.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits from PR #138 have been added to this PR, so this is ready to be merged.
I found a bug in the PyPI package generation -- the generated .whl and .tar.gz files didn't actually contain the crdch_model.py program. Luckily, it was a pretty easy fix, and crdch-model v1.1.1 contains the files and seems to work with the Example Data Workflow.
I don't think the data files are being included, either; there's some example syntax in https://setuptools.pypa.io/en/latest/userguide/declarative_config.html that might help.
Closes #69.