Syncing main with changes from release/v1.3.0
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the CCDH Terminology Service endpoint changed.
This environmental variable can be used to access file (see https://pygsheets.readthedocs.io/en/stable/authorization.html#service-account for details).
This is because @cached_property isn't supported in Python 3.7, blech.
See https://docs.python.org/3/library/constants.html#exit for recommendation.
This PR adds a "dummy sheet test" (#8) -- it runs sheet2linkml with a Google Sheet I've created solely for testing at https://docs.google.com/spreadsheets/d/1HpsF12vl_CeIzV2TEtANeysnh7cy6YOUDdv6fMXT00I/edit#gid=1810442705, and ensures that the output is identical to the schema generated on previous runs, which is included in this PR. In addition to this, this PR also fixes some minor bugs found along with the way: - The CCDH Terminology Service enumeration endpoint changed its format, so we have to modify our API to match it. - The CCDH Terminology Service now returns 404s if the field doesn't exist or is not an enumeration, so we modify our code to catch that possibility. - Fixes #10 by allowing the use of [Google API Service Accounts in an environmental variable](https://pygsheets.readthedocs.io/en/stable/authorization.html#service-account), allowing testing on GitHub Actions. - Added `pytest` to support testing. - Added a command line option to set the Google Sheet ID. - Added checks to ensure that the `logging_config` and `google_sheet_id` command line arguments are set before using them. - Made sheet2linkml explicitly set the error code to `0` in case of successful execution. - Replaced a stray `print()` with `logging.debug()`.
gaurav
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR is merged, create release
v1.3.0from themainbranch.