Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry plugin: use parameters rather than env vars #2025

Closed
lengau opened this issue Dec 11, 2024 · 2 comments · Fixed by #2044
Closed

Poetry plugin: use parameters rather than env vars #2025

lengau opened this issue Dec 11, 2024 · 2 comments · Fixed by #2044
Assignees
@lengau
Labels
Enhancement New feature or request triaged

Comments

@lengau
Copy link
Collaborator

lengau commented Dec 11, 2024

What needs to get done

The Charmcraft version of the poetry plugin uses environment variables to set pip options rather than parameters. With canonical/craft-parts#932 it makes better sense to put this in parameters. This needs to be done before the Charmcraft 3.3 release since it breaks those plugins

Why it needs to get done

Requested by data platform team
@lengau lengau added Enhancement New feature or request triaged labels Dec 11, 2024
@lengau lengau self-assigned this Dec 11, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3794.

This message was autogenerated

@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3795.

This message was autogenerated

lengau added a commit that referenced this issue Dec 16, 2024
@lengau
fix(plugins/poetry): set --no-binary=:all: by param
28880d8 
This moves the environment variable configuration to use a parameter.
This is needed because pip does not load environment variables in a
deterministic order, but the order of these parameters matters.

Requires canonical/craft-parts#940

Fixes #2025

CRAFT-3794
@lengau lengau mentioned this issue Dec 16, 2024
Merged
lengau added a commit that referenced this issue Dec 17, 2024
@lengau
fix(plugins/poetry): set --no-binary=:all: by param (#2044)
0db15c1 
This moves the environment variable configuration to use a parameter.
This is needed because pip does not load environment variables in a
deterministic order, but the order of these parameters matters.

Requires canonical/craft-parts#940

Fixes #2025

CRAFT-3794
lengau added a commit to tmihoc/charmcraft that referenced this issue Dec 19, 2024
@lengau
fix(plugins/poetry): set --no-binary=:all: by param (canonical#2044)
3340b93 
This moves the environment variable configuration to use a parameter.
This is needed because pip does not load environment variables in a
deterministic order, but the order of these parameters matters.

Requires canonical/craft-parts#940

Fixes canonical#2025

CRAFT-3794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengau lengau

Labels
Enhancement New feature or request triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugins/poetry): set --no-binary=:all: by param canonical/charmcraft
1 participant
@lengau