feat(plugins/poetry): add poetry and pip extra args #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
added a commit
to canonical/charmcraft
that referenced
this pull request
Dec 16, 2024
This moves the environment variable configuration to use a parameter. This is needed because pip does not load environment variables in a deterministic order, but the order of these parameters matters. Requires canonical/craft-parts#940 Fixes #2025 CRAFT-3794
This allows more customisation of the poetry and pip commands for advanced users.
lengau
force-pushed
the
work/932/CRAFT-3792
branch
from
7b70112 to
7fa93c2
Compare
mr-cal
approved these changes
Dec 16, 2024
bepri
approved these changes
Dec 16, 2024
lengau
added a commit
to canonical/charmcraft
that referenced
this pull request
Dec 17, 2024
This moves the environment variable configuration to use a parameter. This is needed because pip does not load environment variables in a deterministic order, but the order of these parameters matters. Requires canonical/craft-parts#940 Fixes #2025 CRAFT-3794
lengau
added a commit
to tmihoc/charmcraft
that referenced
this pull request
Dec 19, 2024
This moves the environment variable configuration to use a parameter. This is needed because pip does not load environment variables in a deterministic order, but the order of these parameters matters. Requires canonical/craft-parts#940 Fixes canonical#2025 CRAFT-3794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more customisation of the poetry and pip commands for advanced users.