feat: flask and django, update to paas-app-charmer 1.0.3 #1691
Conversation
|
@javierdelapuente please ping me when this is ready to review |
javierdelapuente
changed the title
|
Hi @lengau , can you have a look at this PR? Thanks! |
javierdelapuente
changed the title
| @@ -134,6 +134,17 @@ def _get_root_snippet(self) -> dict[str, Any]: | |||
| "description": f"{self.framework} application image.", | |||
| }, | |||
| }, | |||
| "charm-libs": [ | |||
| {"lib": "traefik_k8s.ingress", "version": "2"}, | |||
| {"lib": "observability_libs.juju_topology", "version": "0"}, | |||
There was a problem hiding this comment.
Is there any worry with version 0 libs here that they'll make breaking changes?
There was a problem hiding this comment.
I think for some reason it is common to start the versions on version 0 for charm libraries, I have seen it a lot. There generally shouldn't be breaking changes within any major version
There was a problem hiding this comment.
Hopefully LIBPATCH will not introduce non-breaking changes. https://juju.is/docs/sdk/document-your-charm-library.
I do not think the LIBAPI 0 has the usual semantics of semver with major number 0 (that any breaking change can happen). In the wild, we haven't had problems with that either.
There was a problem hiding this comment.
Approving with the understanding that:
- charms using these extensions with
charm-libsdefined in acharmcraft.yamlwill now get an error - there is not a mechanism to override or modify the charm-libs defined by the extension
- this can be added later as a feature
- these extensions are experimental, so this is an OK change
I will add a new PR with a fix and a test. As you point out, the error is not nice and no merging is possible. Thanks. |
As pointed by @mr-cal in #1691 (review), the Flask extension fails when a `charm-libs` is already defined in a `charmcraft.yaml`, with a not very clear message because of an `AttributeError` exception. This PR allows having a `charm-libs` in the original `charmcraft.yaml`, and will combine both `charm-libs` lists (if there are duplicated elements they will be only downloaded once). Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Version 1.0.3 of paas-app-charmer has been released, providing the new following functionality:
charmcraft.yamlfile is set to false and the integration is not active, paas-app-charmer will block the charm (and stop all the services).This PR adapts charmcraft to get advantage of that functionality.
Besides those changes,
charm-libshas been added to the extension (including the new two new libraries for SAML and S3). That way the user can docharmcraft fetch-libsinstead of onefetch-libper library.