Flask extension. Allow charm-libs to be extended by the user #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierdelapuente
force-pushed
the
fix-charm-libs-merging-extension
branch
from
07d3500 to
05f51ea
Compare
|
Hi @lengau can you have a look at this PR. It addresses the issue pointed in #1691 (review). Thank you! |
lengau
approved these changes
Jul 16, 2024
|
Looks good to me, thanks! |
mattculler
approved these changes
Jul 16, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed by @mr-cal in #1691 (review), the Flask extension fails when a
charm-libsis already defined in acharmcraft.yaml, with a not very clear message because of anAttributeErrorexception.This PR allows having a
charm-libsin the originalcharmcraft.yaml, and will combine bothcharm-libslists (if there are duplicated elements they will be only downloaded once).