feat: backport rock upload to charmcraft 2.x #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies the Skopeo class from: #1696
lengau
force-pushed
the
work/CRAFT-2921-backport
branch
from
f48c94d to
74967ea
Compare
lengau
force-pushed
the
work/CRAFT-2921-backport
branch
from
74967ea to
80f9228
Compare
tigarmo
approved these changes
Jun 13, 2024
lengau
force-pushed
the
work/CRAFT-2921-backport
branch
from
3314f18 to
54ed103
Compare
mr-cal
approved these changes
Jun 13, 2024
carlcsaposs-canonical
added a commit
to canonical/data-platform-workflows
that referenced
this pull request
Jun 19, 2024
charmcraft 2.7.0 contains a fix for multi-arch OCI images issue: canonical/charmcraft#1685 fix: canonical/charmcraft#1708 However, it fixes it in a "backwards-compatible" way—if the image is available locally, it will still upload it incorrectly. Stop downloading the image locally & always use GHCR so that charmcraft uploads the image correctly This will break on charmcraft < 2.7.0
carlcsaposs-canonical
added a commit
to canonical/data-platform-workflows
that referenced
this pull request
Jun 19, 2024
…#198) charmcraft 2.7.0 contains a fix for multi-arch OCI images issue: canonical/charmcraft#1685 fix: canonical/charmcraft#1708 However, it fixes it in a "backwards-compatible" way—if the image is available locally, it will still upload it incorrectly. Stop downloading the image locally & always use GHCR so that charmcraft uploads the image correctly This will break on charmcraft < 2.7.0
lengau
added a commit
that referenced
this pull request
Jul 19, 2024
Allows Charmcraft 2.7+ to use skopeo urls directly when uploading an oci-image resource. Example: ``` $ charmcraft upload-resource lengau-test-charm example-image --image docker://ghcr.io/canonical/charmed-mysql:8.0.36-22.04_edge Image not found locally. Passing path directly to skopeo. Revision 6 created of resource 'example-image' for charm 'lengau-test-charm'. $ ```
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Charmcraft 2.7+ to use skopeo urls directly when uploading an oci-image resource.
Example: