Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update to ruff 0.9.0 formatting #2074

Merged
merged 2 commits into from
Jan 13, 2025
Merged

style: update to ruff 0.9.0 formatting #2074

merged 2 commits into from
Jan 13, 2025

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jan 13, 2025

This handles the cases where lint starts failing with ruff 0.9.0.

This handles the cases where lint starts failing with ruff 0.9.0.
@lengau lengau requested review from bepri and mr-cal January 13, 2025 18:07
@lengau lengau enabled auto-merge January 13, 2025 18:07
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ahead of time as this is nitpicky, but...

In the spirit of updating a linter, here's a few pyproject errors that could be added on to this:

  • git_describe_command should be an array - just take care to not repeat the mistakes fixed in fix: correct package versioning error craft-parts#957
  • lint.select TCH rules should now be TC
  • lint.ignore should drop the deprecated ANN10
  • tool.ruff.lint.per-file-ignores should drop the deprecated PT004 for test files

@lengau
Copy link
Collaborator Author

lengau commented Jan 13, 2025

@bepri agreed in all cases except the first - that craft-parts change should be upstreamed to starbase and we can get it from there.

@lengau lengau disabled auto-merge January 13, 2025 18:58
@lengau lengau merged commit af377cd into main Jan 13, 2025
22 of 23 checks passed
@lengau lengau deleted the style/ruff-0.9 branch January 13, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants