Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct package versioning error #957

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: correct package versioning error #957

merged 2 commits into from
Jan 8, 2025

Conversation

bepri
Copy link
Contributor

@bepri bepri commented Jan 8, 2025

  • Have you signed the CLA?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

690fe31 broke the versioning command and caused @ git+ downloads of this repository to get versioned as 0.0.

The default git_describe_command is an array, and the schema requires it to be an array, but it was previously a string anyways. The broken commit attempted to correct this, but it appears that the git_describe_command variable is passed directly to something unaware of shell expansions. This meant that the arguments '[0-9]*.[0-9]*.[0-9]*' and '*[^0-9.]*' were invalid as the *s were fine but the 's only confused it.

This PR removes those ticks. Confirmed to correctly publish the version number with both uv build and python3 -m build.

@bepri bepri requested review from lengau and mr-cal January 8, 2025 19:14
@bepri bepri self-assigned this Jan 8, 2025
@bepri bepri force-pushed the work/fix-versioning branch from cb91a15 to 37019b2 Compare January 8, 2025 19:16
@bepri bepri requested review from a team and removed request for lengau January 8, 2025 19:16
@mr-cal mr-cal requested a review from a team January 8, 2025 19:16
@bepri bepri merged commit 139c4d5 into main Jan 8, 2025
13 checks passed
@bepri bepri deleted the work/fix-versioning branch January 8, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants