fix: correct package versioning error #957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/reference/changelog.rst
)?690fe31 broke the versioning command and caused
@ git+
downloads of this repository to get versioned as0.0
.The default
git_describe_command
is an array, and the schema requires it to be an array, but it was previously a string anyways. The broken commit attempted to correct this, but it appears that thegit_describe_command
variable is passed directly to something unaware of shell expansions. This meant that the arguments'[0-9]*.[0-9]*.[0-9]*'
and'*[^0-9.]*'
were invalid as the*
s were fine but the'
s only confused it.This PR removes those ticks. Confirmed to correctly publish the version number with both
uv build
andpython3 -m build
.