Skip to content

Commit

Permalink
Update pull request template with steps to follow for file format cha…
Browse files Browse the repository at this point in the history
…nges (Infra) (#1196)

* Update pull request template with steps to follow for file format changes (Infra)
  • Loading branch information
mz2 authored Apr 18, 2024
1 parent e1f796b commit 14059dc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Describe your changes here:
- What's the problem solved (briefly, since the issue is where this is elaborated in more detail).
- Introduce your implementation approach in a way that helps reviewing it well.
- Alert the reviewer of any changes that involve data persistence: present examples of file format changes as part of the PR description (e.g. new fields of data stored in unit or submission output).
-->

## Resolved issues
Expand All @@ -46,6 +47,7 @@ Please make sure that...
- Documentation in the repository, including contribution guidelines.
- Process documentation outside the repository.
- Tests are included for the changed functionality in this PR. If to be merged without tests, please elaborate why.
- When breaking changes and other key changes are introduced, the PR having been merged should be broadcast (in demo sessions, IM, Discourse) with relevant references to documentation. This is an opportunity to gather feedback and confirm that the changes and how they are documented are understood.
-->

## Tests
Expand All @@ -55,4 +57,3 @@ Please make sure that...
- Please provide a list of what tests were run and on what platform/configuration.
- Remember to check the test coverage of your PR as described in CONTRIBUTING.md
-->

0 comments on commit 14059dc

Please sign in to comment.