Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template with steps to follow for file format changes (Infra) #1196

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

mz2
Copy link
Collaborator

@mz2 mz2 commented Apr 18, 2024

Description

Updated pull request template to give better chances of file format changes and breaking changes to be broadcast after PR getting merged.

Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo fix proposed below

.github/pull_request_template.md Outdated Show resolved Hide resolved
Co-authored-by: kissiel <maciej.kisielewski@canonical.com>
Copy link
Contributor

@kissiel kissiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mz2 mz2 merged commit 14059dc into main Apr 18, 2024
6 checks passed
@mz2 mz2 deleted the mz2-patch-1 branch April 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants