Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest plugin assert_error #162

Open
lengau opened this issue Jun 30, 2023 · 2 comments · Fixed by #218
Open

pytest plugin assert_error #162

lengau opened this issue Jun 30, 2023 · 2 comments · Fixed by #218
Labels
Breaking change Enhancement New feature or request triaged Will be worked on at some point

Comments

@lengau
Copy link
Contributor

lengau commented Jun 30, 2023

What needs to get done

Like the various message asserts, the pytest plugin's emitter should be able to assert that the error method was called and check the corresponding craft error.

Why it needs to get done

Right now there's no way to check that the correct error was sent to emit.error

lengau added a commit that referenced this issue Jan 11, 2024
lengau added a commit that referenced this issue Jan 11, 2024
lengau added a commit that referenced this issue Sep 13, 2024
@lengau lengau added Enhancement New feature or request triaged Will be worked on at some point labels Nov 15, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3686.

This message was autogenerated

@lengau lengau reopened this Dec 12, 2024
@lengau
Copy link
Contributor Author

lengau commented Dec 12, 2024

This is getting reverted in #311.

The feature works, but I didn't catch when creating it that it's a breaking change, so we'll need to assign it to the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Enhancement New feature or request triaged Will be worked on at some point
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants