Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pytest): add an assert_error plugin method #218

Merged
merged 2 commits into from
Nov 22, 2024
Merged

feat(pytest): add an assert_error plugin method #218

merged 2 commits into from
Nov 22, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jan 11, 2024 •
edited
Loading

Fixes #162

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau force-pushed the 162/pytest-assert-error branch from 79bfa9d to 8fef27c Compare January 11, 2024 19:33
@lengau lengau requested review from tigarmo and cmatsuoka February 20, 2024 19:57
@lengau lengau force-pushed the 162/pytest-assert-error branch from 0a320ae to 0f842af Compare September 13, 2024 13:06
cmatsuoka
cmatsuoka approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigarmo tigarmo merged commit dd3fe83 into main Nov 22, 2024
11 checks passed
@tigarmo tigarmo deleted the 162/pytest-assert-error branch November 22, 2024 15:39
lengau added a commit that referenced this pull request Dec 12, 2024
@lengau
Revert "feat(pytest): add an assert_error plugin method (#218)"
f0affe1 
This reverts commit dd3fe83.
@lengau lengau mentioned this pull request Dec 12, 2024
Merged
lengau added a commit that referenced this pull request Dec 12, 2024
@lengau
fix(pytest): revert "add an assert_error plugin method" (#311)
84df9bf 
Reverts #218

Breaks #162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest plugin assert_error
3 participants
@lengau @cmatsuoka @tigarmo