Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify all the tox jobs into the top-level #50

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Unify all the tox jobs into the top-level #50

merged 8 commits into from
Mar 28, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Mar 22, 2024 •
edited
Loading

Unifies to a single pyproject.toml and applies linter rules to all .py files

Depends on #51 to be first merged

@addyess addyess requested a review from a team as a code owner March 22, 2024 13:50
@addyess addyess mentioned this pull request Mar 22, 2024
Merged
@addyess
Copy link
Contributor Author

addyess commented Mar 26, 2024

@louiseschmidtgen I got around to removing all those extraneous pyproject.toml files

louiseschmidtgen
louiseschmidtgen approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up all these files,looks like we cover the COS code as well now! Nice!
Overall, LGTM I only have a rename suggestion.

.github/workflows/tests-k8s.yaml Show resolved Hide resolved
@addyess addyess merged commit ef1a2ae into main Mar 28, 2024
22 checks passed
@addyess addyess deleted the chore/lint-clean-up branch March 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen louiseschmidtgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @louiseschmidtgen