Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COS] Push deeper linting into the repo for integration and unit testing #51

Merged
merged 2 commits into from
Mar 26, 2024
Merged

[COS] Push deeper linting into the repo for integration and unit testing #51

merged 2 commits into from
Mar 26, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Mar 22, 2024

Paired with #50, this handled other linting issues within the repo

@addyess addyess requested a review from a team as a code owner March 22, 2024 18:01
mateoflorido
mateoflorido reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I would appreciate one COS run just to be sure everything is working as expected

@addyess addyess changed the title Push deeper linting into the repo for integration and unit testing [COS] Push deeper linting into the repo for integration and unit testing Mar 22, 2024
@addyess addyess closed this Mar 22, 2024
@addyess addyess reopened this Mar 22, 2024
@addyess
Pure setup fixtures (which yeild nothing) are renamed starting with '…
d20be07 
…_' since they appear to pylint as unused arguments
bschimke95
bschimke95 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 8d943cc into main Mar 26, 2024
22 checks passed
@addyess addyess deleted the akd/deeper-linting branch March 26, 2024 13:05
@addyess addyess mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido left review comments

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addyess @mateoflorido @bschimke95