ci: refactor on push and release workflows to use same cached build used in tests #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NohaIhab
commented
Jan 21, 2025
There was a problem hiding this comment.
Renamed from release.yaml for consistency with data repos
NohaIhab
commented
Jan 22, 2025
NohaIhab
commented
Jan 22, 2025
DnPlas
approved these changes
Jan 24, 2025
* ci, tests: pass charm artefacts to deploy and test charms This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: #639 Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax skip: remove duplicated download-charms remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output skip: rename job in needs pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658)
NohaIhab
force-pushed
the
KF-6756-refactor-ci-on-push-release-publish
branch
from
e2459d8 to
11af2a7
Compare
NohaIhab
merged commit 3f1efc3
into
KF-6684-refactor-ci-with-build
73 of 83 checks passed
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #655
Closes #650
Closes #656
Summary
This PR refactors the repo's CI to use the same cached builds for individual integration tests, release charm, and promote workflows.
The workflows are refactored to follow the same structure and conventions as in data platform teams. It includes the following changes:
integrate.yamland renames it toci.yamlrelease.yamlwhich reused data platform workflows'release_charm.yamlon_pull_request.yamlandon_push.yamlworkflows, instead they reuse theci.yamlfor tests andrelease.yamlfor releasing to charmhubrelease.yamltopromote.yamlNote to reviewers: