chore: use charmcraft latest/candidate for check libs #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DnPlas
approved these changes
Jan 23, 2025
NohaIhab
added a commit
to canonical/kfp-operators
that referenced
this pull request
Jan 24, 2025
NohaIhab
pushed a commit
to canonical/kfp-operators
that referenced
this pull request
Jan 24, 2025
* ci, tests: pass charm artefacts to deploy and test charms This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: #639 Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax skip: remove duplicated download-charms remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output skip: rename job in needs pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658)
NohaIhab
added a commit
to canonical/kfp-operators
that referenced
this pull request
Jan 24, 2025
Use single (cached) build for integration tests & release Fix hardcoded path for `platforms` syntax remove workflow dispatch from release.yaml not needed add description for outputs rename get charm paths job and channel output pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95 Use stage instead of prime in charmcraft files part (#658) Co-authored-by: Daniela Plascencia <daniela.plascencia@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily changes the channel of charmcraft used in check-libs action to
latest/candidate, by default it uses latest/stable which currently does not support platforms syntax. It is needed to work on the charmcraft.yamlST124changes, for example canonical/kubeflow-tensorboards-operator#154.