Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all projects parameter to resolve image fingerprints in permission config #1017

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 29, 2024

Done

  • Use all projects parameter to resolve image fingerprints in permission config
  • Show project for images in permission selector
  • Since Add all projects support to fetch images lxd#14126 got merged, this is now unblocked. For older versions (non latest/edge) the parameter won't harm so we don't need to consume the api extension for this feature.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • configure image permissions for a lxd deployment that has images in different projects
    • the images from all projects should be resolved to names in the permission selection and editing when assigning permissions to groups.

…n permission config. show project for images in permission selector

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, finally :)

@edlerd edlerd merged commit fa007c4 into canonical:main Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants