Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all projects support to fetch images #14126

Closed
edlerd opened this issue Sep 18, 2024 · 0 comments · Fixed by #14260
Closed

Add all projects support to fetch images #14126

edlerd opened this issue Sep 18, 2024 · 0 comments · Fixed by #14260
Assignees
Labels
Improvement Improve to current situation
Milestone

Comments

@edlerd
Copy link
Contributor

edlerd commented Sep 18, 2024

Required information

  • Distribution: snap
  • Distribution version: 6.1

Issue description

Add a way to fetch images from all projects. Suggesting a new param: GET 1.0/images?all-projects=true. A similar parameter exists on the instance endpoint.

Motivation: We need all images for the permission selection in LXD-UI. We present the list of images to create a permission, and the auth API only gives us fingerprints for the images. So we'd like to fetch all images to show the nice names. This currently only works for images in the default project, others stay with the fingerprint, as we can't load the images for all projects.

@tomponline tomponline added this to the lxd-6.2 milestone Sep 18, 2024
@tomponline tomponline added the Improvement Improve to current situation label Sep 18, 2024
@tomponline tomponline modified the milestones: lxd-6.2, lxd-6.3 Nov 27, 2024
edlerd added a commit to canonical/lxd-ui that referenced this issue Nov 29, 2024
…n config (#1017)

## Done

- Use all projects parameter to resolve image fingerprints in permission
config
- Show project for images in permission selector
- Since canonical/lxd#14126 got merged, this
is now unblocked. For older versions (non latest/edge) the parameter
won't harm so we don't need to consume the api extension for this
feature.

## QA

1. Run the LXD-UI:
- On the demo server via the link posted by @webteam-app below. This is
only available for PRs created by collaborators of the repo. Ask
@mas-who or @edlerd for access.
- With a local copy of this branch, [build and run as described in the
docs](../CONTRIBUTING.md#setting-up-for-development).
2. Perform the following QA steps:
- configure image permissions for a lxd deployment that has images in
different projects
- the images from all projects should be resolved to names in the
permission selection and editing when assigning permissions to groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improve to current situation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants