LXD: Fix start and stop for FROZEN instances
#13452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
frozen-instance-stop
branch
from
e26e22f to
10ae19a
Compare
|
@MggMuggins if you are using patches from Incus then you need to cherry pick specific commits to maintain attribution and add the Apache 2.0 license footer to the commit message (see link to doc in lxd private mm channel). |
|
@tomponline This does not use changes from incus; the approach incus took was to add a |
tomponline
reviewed
May 10, 2024
tomponline
requested changes
May 10, 2024
tomponline
reviewed
May 10, 2024
Fixes canonical#12578 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Fixes canonical#12491 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
frozen-instance-stop
branch
from
10ae19a to
1915d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--force(aka"timeout": 0in the API); frozen instances must either be started explicitly before graceful stop or forcefully shut downPUT /instances/{name}/statewith"action": "start"now unfreezes frozen instanceslxc start --allfor frozen instanceslxc start --all --projectdoesn't work withFROZENinstances #12491This was fixed in incus with the same patch as in #12493
Not sure if this warrants an API extension: if users were expecting
startto fail on frozen instances, then this does break that workflow. Happy to add one if needed.