Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc: Fix bulk unfreeze (from Incus) #14136

Merged
merged 1 commit into from
Sep 25, 2024
Merged

lxc: Fix bulk unfreeze (from Incus) #14136

merged 1 commit into from
Sep 25, 2024

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Sep 19, 2024 •
edited
Loading

Cherry-picked from lxc/incus#387. Tested locally ✅.

@monstermunchkin @kadinsayani
lxd: Fix bulk unfreezing
9e4bb7f 
This fixes the check for bulk unfreezing. Instances should only be
skipped if they are not frozen.

Signed-off-by: Thomas Hipp <thomashipp@gmail.com>
(cherry picked from commit 7b2b874081c5fd75d3c96d210b412ffdf9497172)
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
License: Apache-2.0
@MggMuggins
Copy link
Contributor

@kadinsayani Some additional context in #13452, not sure if we want to introduce a lxc resume since I think lxc start is overloaded to do the same.

@kadinsayani
Copy link
Contributor Author

@kadinsayani Some additional context in #13452, not sure if we want to introduce a lxc resume since I think lxc start is overloaded to do the same.

Thanks for providing additional context on this one 😄. I'll wait for Tom's input on this and close the PR if we decide against adding lxc resume.

@tomponline
Copy link
Member

Thanks for providing additional context on this one 😄. I'll wait for Tom's input on this and close the PR if we decide against adding lxc resume.

OK lets not introduce a new command as @MggMuggins says, but is there a bug to be fixed here anyway?

@kadinsayani kadinsayani force-pushed the fix-bulk-unfreeze-and-add-resume-subcmd branch from 2ac502d to 9e4bb7f Compare September 23, 2024 14:08
@kadinsayani
Copy link
Contributor Author

OK lets not introduce a new command as @MggMuggins says, but is there a bug to be fixed here anyway?

Sounds good. Yes, I've rebased to only include the bug fix.

@kadinsayani kadinsayani changed the title lxc: Fix bulk unfreeze and add resume subcmd (from Incus) lxc: Fix bulk unfreeze (from Incus) Sep 23, 2024
@tomponline tomponline merged commit fce1ec2 into canonical:main Sep 25, 2024
28 of 30 checks passed
@kadinsayani kadinsayani deleted the fix-bulk-unfreeze-and-add-resume-subcmd branch September 25, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadinsayani @MggMuggins @tomponline @monstermunchkin