Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't patch private ops class #519

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Issue

The tests currently patch a private ops class. The private names have no compatibility guarantee, and this will stop working in an upcoming ops release.

Solution

Remove the patching, which is not required in modern ops. Also update the expect default IP (from Cloudflare's DNS server, which we shouldn't be using anyway).

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (e7c1809) to head (37e6a01).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   66.25%   65.44%   -0.82%     
==========================================
  Files          17       18       +1     
  Lines        3180     4092     +912     
  Branches      424      588     +164     
==========================================
+ Hits         2107     2678     +571     
- Misses        935     1205     +270     
- Partials      138      209      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp requested review from a team, paulomach, taurus-forever, shayancanonical and carlcsaposs-canonical and removed request for a team September 11, 2024 09:48
Copy link
Contributor

@shayancanonical shayancanonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @tonyandrewmeyer , thank you for the contribution!
Good to hear it is no longer necessary!!!

P.S. should we share this information locally OR you are going to patch all those repos:

14:23:00 ✔ taurus:~/canonical/git/$ rg patch_network_get . | awk -F'/' '{print $2}' | uniq
mysql-operator
pgbouncer-operator
postgresql-operator
postgresql-k8s-operator
s3-integrator
mongodb-operator
mongodb-k8s-operator
opensearch-operator

@tonyandrewmeyer
Copy link
Contributor Author

P.S. should we share this information locally OR you are going to patch all those repos:

14:23:00 ✔ taurus:~/canonical/git/$ rg patch_network_get . | awk -F'/' '{print $2}' | uniq
mysql-operator
pgbouncer-operator
postgresql-operator
postgresql-k8s-operator
s3-integrator
mongodb-operator
mongodb-k8s-operator
opensearch-operator

I've opened PRs for prometheus-k8s-operator, grafana-k8s-operator, postgresql-operator, postgresql-k8s-operator/pull/692, and (obviously) mysql-operator. My hope was to let the others (I have a list of 12 that I could find) know and let teams do the fix themselves, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants