Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop patching the private ops.testing._TestingModelBackend class #50

Open
tonyandrewmeyer opened this issue Sep 12, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@tonyandrewmeyer
Copy link

Steps to reproduce

  1. grep _TestingModelBackend

Expected behavior

No results.

Actual behavior

Results.

Versions

Operating system: N/A

Juju CLI: N/A

Juju agent: N/A

Charm revision: N/A

Log output

Juju debug log: N/A

Additional context

As _TestingModelBackend is a private class, no guarantees are made about compatibility, and the tests relying on patching this class will break in an upcoming ops release.

The patching is actually no longer required with recent versions of ops, so mostly the patching can just be removed, with the occasional add_network call potentially required.

You can use these PRs as examples if needed:

If any assistance is required, please reach out to @canonical/charm-tech and we'll be happy to help!

@tonyandrewmeyer tonyandrewmeyer added the bug Something isn't working label Sep 12, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/DPE-5447.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant