Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove patching of private ops class #692

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Issue

The tests currently patch a private ops class. No compatibility guarantees are provided for private names, and this will stop working in an upcoming ops release.

Solution

Remove the patching - it's no longer required with modern versions of ops anyway. Also adjust the expected default IP (from Cloudflare's DNS server, which we shouldn't be using anyway).

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (ef14e32) to head (9668caa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files          11       11           
  Lines        2952     2952           
  Branches      514      514           
=======================================
  Hits         2088     2088           
  Misses        754      754           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp requested review from a team, taurus-forever, dragomirp, marceloneppel and lucasgameiroborges and removed request for a team September 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants