Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove patching of a private ops class #617

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

The tests currently patch a private ops class. The private names have no compatibility guarantees, and this will break in an upcoming ops release.

Remove the patching, which is generally not required with modern ops, and update a couple of expected IPs to the default ones (rather than Cloudflare's DNS server, which we should not really use anyway).

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.81%. Comparing base (f9032b8) to head (4de5a03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files          12       12           
  Lines        3039     3039           
  Branches      537      537           
=======================================
  Hits         2152     2152           
  Misses        771      771           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp requested review from a team, taurus-forever, dragomirp, marceloneppel and lucasgameiroborges and removed request for a team September 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants