Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump juju 3.1 -> 3.4 in track/1.8 #349

Closed
wants to merge 5 commits into from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 9, 2024

misohu and others added 5 commits November 30, 2023 11:25
* Use use-istio config in charm.py
* Update GH files for issue templates and Jira automation

This PR updates the .github files to
* Ensure we have a file for tasks/enhancements
* Ensure we expose dod in task issues
* Use the FastAPI for ticket sync, and not JIRA_URL

* review: Update task template
* fix: expose metrics port using kubernetes_service_patch lib

This commit ensures the metrics port is exposed in the Kubernetes Service for the jupyter-controller
using the kubernetes_service_patch lib. This makes the metrics endpoint reachable from external
prometheus scraper.
This commit also changes the unit tests slightly to adapt to the added service patcher.

Part of canonical/bundle-kubeflow#564

* tests: add an assertion for checking unit is available

The test_prometheus_grafana_integration test case was doing queries to prometheus
and checking the request returned successfully and that the application name and model
was listed correctly. To make this test case more accurately, we can add an assertion that
also checks that the unit is available, this way we avoid issues like the one described in
canonical/bundle-kubeflow#564.

Part of canonical/bundle-kubeflow#564
* Remove `uid` from the `datasource` fields.
* fix typo
* Add tag `ckf` to dashboard.
* Increase retry_for_attempts to 10 attempts
* unpin prometheus

Part of canonical/bundle-kubeflow#856
Refs canonical/bundle-kubeflow#834
@DnPlas DnPlas requested a review from a team as a code owner April 9, 2024 09:17
@DnPlas DnPlas changed the title ci: bump juju 3.1 -> 3.4 in ci: bump juju 3.1 -> 3.4 in track/1.8 Apr 9, 2024
@DnPlas DnPlas closed this Apr 9, 2024
@DnPlas DnPlas deleted the KF-5535-bump-juju-3.4-in-track branch April 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants