[MISC] Hold database created hook for pg_hba changes #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
added
the
not bug or enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1002 +/- ##
===========================================
+ Coverage 72.16% 72.33% +0.17%
===========================================
Files 14 14
Lines 3693 3680 -13
Branches 525 524 -1
===========================================
- Hits 2665 2662 -3
+ Misses 829 821 -8
+ Partials 199 197 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
changed the title
dragomirp
commented
Jun 17, 2025
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | ||
| # to 0 if you are raising the major API version | ||
| LIBPATCH = 55 | ||
| LIBPATCH = 52 |
There was a problem hiding this comment.
Setting to stale version, so we don't release this on the v0 track.
dragomirp
commented
Jun 17, 2025
There was a problem hiding this comment.
Bump linting and dependency python to noble (3.12).
dragomirp
commented
Jun 17, 2025
dragomirp
commented
Jun 17, 2025
Comment on lines
-309
to
-316
| def _update_unit_status_on_blocking_endpoint_simultaneously(self): | ||
| """Clean up Blocked status if this is due related of multiple endpoints.""" | ||
| if ( | ||
| self.charm._has_blocked_status | ||
| and self.charm.unit.status.message == ENDPOINT_SIMULTANEOUSLY_BLOCKING_MESSAGE | ||
| and not self._check_multiple_endpoints() | ||
| ): | ||
| self.charm.unit.status = ActiveStatus() |
There was a problem hiding this comment.
We no longer have multiple endpoints.
dragomirp
requested review from
a team,
taurus-forever and
marceloneppel
and removed request for
a team
marceloneppel
approved these changes
Jun 17, 2025
taurus-forever
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of canonical/postgresql-operator#959 from VM
Checklist