[MISC] Fix timeouts in 14 to 16 merge #959

dragomirp · 2025-06-10T14:35:07Z

Try to fix the consistent timeouts in async replication and new relation tests.

Checklist

I have added or updated any relevant documentation.
I have cleaned any remaining cloud resources from my accounts.

codecov · 2025-06-10T14:36:41Z

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (a8cfa1f) to head (3c98a2c).
Report is 1 commits behind head on sync14to16.

Files with missing lines	Patch %	Lines
src/charm.py	0.00%	10 Missing ⚠️
src/cluster.py	11.11%	7 Missing and 1 partial ⚠️
src/relations/postgresql_provider.py	75.00%	2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.92%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (69.80%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@              Coverage Diff               @@
##           sync14to16     #959      +/-   ##
==============================================
+ Coverage       69.78%   69.80%   +0.02%     
==============================================
  Files              16       16              
  Lines            3779     3786       +7     
  Branches          550      552       +2     
==============================================
+ Hits             2637     2643       +6     
  Misses           1005     1005              
- Partials          137      138       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dragomirp · 2025-06-12T08:42:04Z

lib/charms/postgresql_k8s/v1/postgresql.py

+    def is_user_in_hba(self, username: str) -> bool:
+        """Check if user was added in pg_hba."""
+        connection = None
+        try:
+            with self._connect_to_database() as connection, connection.cursor() as cursor:
+                cursor.execute(
+                    SQL(
+                        "SELECT COUNT(*) FROM pg_hba_file_rules WHERE {} = ANY(user_name);"
+                    ).format(Literal(username))
+                )
+                return cursor.fetchone()[0] > 0
+        except psycopg2.Error as e:
+            logger.debug(f"Failed to check pg_hba: {e}")
+            return False
+        finally:
+            if connection:
+                connection.close()


Check if a user has been added to pg_hba

dragomirp · 2025-06-12T08:43:37Z

src/charm.py

+        except PostgreSQLListUsersError:
+            logger.debug("relations_user_databases_map: Unable to get users")
+            return {USER: "all", REPLICATION_USER: "all", REWIND_USER: "all"}


Handling in the property, because otherwise we cannot regenerate the configuration.

dragomirp · 2025-06-12T08:47:55Z

src/relations/postgresql_provider.py

-            return
-
-        self.charm.update_config()
+            for attempt in Retrying(stop=stop_after_attempt(3), wait=wait_fixed(1)):


Hold the hook until the user is added to pg_hba or timeout. Locally for me it's happening on the first try, but we may want to increase the timeout to accommodate for variance in hw/storage. On timeout, the topology observer should detect the changes when they become available.

dragomirp · 2025-06-12T08:49:20Z

src/relations/postgresql_provider.py

                )
            )

-    def _on_relation_changed(self, event: RelationChangedEvent) -> None:


Checking for pg_hba changes before releasing database_requested should make this hook redundant.

dragomirp · 2025-06-12T08:50:15Z

src/cluster.py

+        if not self.is_patroni_running():
+            return False


If there's no service running, there's no point calling the rest API.

Can we try to backport this to plain 14/edge.
It smells to me as a game changes for many long-wasting activities.

Should it also be included in member_inactive() below (and maybe all other requests.get(http://localhost/cluster) requests).

Can we try to backport this to plain 14/edge. It smells to me as a game changes for many long-wasting activities.

If the merge goes well, we should backport both this and the pg_hba check.

Should it also be included in member_inactive() below (and maybe all other requests.get(http://localhost/cluster) requests).

We can give it a go, but lets get the 14/edge changes first.

Backport PR: #963.

dragomirp · 2025-06-12T08:51:35Z

tests/integration/helpers.py

+    timeout=2000,
+    idle_period: int = 30,


Async seems to fit in the timeout/idle periods now, but leaving the parameters exposed in case we want to tweak.

dragomirp · 2025-06-12T08:52:21Z

tests/integration/ha_tests/test_async_replication.py

Scale the clusters together in parallel.

taurus-forever

Thank you! Dragomir!!!

taurus-forever · 2025-06-12T09:00:36Z

src/cluster.py

+        if not self.is_patroni_running():
+            return False


Can we try to backport this to plain 14/edge.
It smells to me as a game changes for many long-wasting activities.

Should it also be included in member_inactive() below (and maybe all other requests.get(http://localhost/cluster) requests).

marceloneppel

LGTM!

* [MISC] Use latest/stable lxd (#804) * Use latest stable lxd * Test tweaks * Test tweaks * Update canonical/data-platform-workflows action to v31.0.1 (#805) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-6874] Poll all members in the cluster topology script (#810) * Poll all members in the cluster topology script * Dual branch config * Unit tests and bugfixes * Add peers when starting the observer * Retry sync up checks * [DPE-6572] Add wal_keep_size config option (#799) * Add wal_keep_size config option Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove parameter addition Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Reset durability_wal_keep_size value to PG default Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Create pull_request_template.md (#814) * Create SECURITY.md (#822) * Update README file's security section (#827) * Refactor headings for syntax best practice * Update the Security section * Sync docs from Discourse (#796) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * [MISC] Conditional checksum calculation (#812) * Bump boto * Conditional checksum calculation * [DPE-6218] Static code analysis (#828) * Create tiobe_scan.yaml * Remove push trigger * [MISC] Disable landscape subordinate test lxd (#831) * Set series for ubuntu-advantage test and disable the landscape test * Revert to LTS LXD * Update charmcraft.yaml build tools (#815) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Update snapped PostgreSQL (#832) * [DPE-6345] LDAP I: Create access groups (#823) * [DPE-6345] LDAP II: Include charm libs (#824) * [DPE-6345] LDAP III: Define config and handlers (#825) * [DPE-6345] LDAP IV: Define snap service (#838) * [DPE-6345] LDAP V: Define mapping option (#849) * [MISC] Disable network cut tests on arm (#844) * Disable network cut tests on arm * Back to LXD 5 * [DPE-6815] disable pgaudit during extensions changes (#842) * disable pgaudit during extensions changes * Bump libs * Lock file maintenance Python dependencies (main) (#816) * Lock file maintenance Python dependencies * Fix linting --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> * Update dependency uv to v0.6.16 (#847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-6664] Make username mandatory in set-password (#846) * Make username mandatory * Second get password method * Default in get-password * Add conditional expose directive (#853) * Lock file maintenance Python dependencies (#854) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Mandatory scope for promote action (#856) * Update charmcraft.yaml build tools (#860) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Lock file maintenance Python dependencies (#861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Sync docs from Discourse (#850) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * [MISC] Extend relation-user listing syntax (#868) * Move _update_member_ip call to correctly remove Raft cluster member when network is cut Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix coverage Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Sync libs (#884) * Update refresh tests to modify charm to ensure refresh off edge or stable * Fix lint warnings * Store temporary charms in /tmp for upgrade_from_stable tests * Use force-refresh-start instead of forcing refresh by updating versions * Remove runner password (#913) * [DPE-6898] User->databases pg_hba rules (#885) * Restrict each user to their allowed databases Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix sync users on replicas Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add default landscape user permission Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Increase sleep time in pg_hba test, fix user->database mapping for upgrade from stable and skip event trigger function code when not a superuser Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improve users list check Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix raft reinitialisation in tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Decrease the amount of API calls by one Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Check users list directly Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Tweak test fast interval Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improvements to avoid replica restart while syncing from primary Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix linting Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Handle same snap revision situation in upgrade tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Merge Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improvement to avoid replica restart while syncing from primary Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Run stop-continuous-writes action only once Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Increase sleep time in Juju spaces test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update charmcraft.yaml build tools (#871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Remove JujuVersion warning in 14/edge (#933) * Remove JujuVersion warning * Update libs * Refactor v14 documentation for Sphinx (#919) * initial starter pack transfer * update conf.py * import processed discourse pages * fix internal references and some broken URLs * fix some style errors * organize navigation * remove h1 heading anchors * add images to repository * edit home page * update .readthedocs.yaml * remove docs/requirements.txt from .gitignore scope * fix incorrect paths * remove shell syntax from code blocks * remove juju 2 banners * fix dropdown formatting * fix and polish admonitions, collapsible, and misc formatting * remove v16 docs * remove reference to nonexistant page * Join all tutorial pages * rename how-to-guides to how-to * polish cloud deployment guides and rename leftover how-to-guide references * polish and sync how-to guides with k8s * remove discourse sync workflow * specify channel on all deploy commands * misc polishing, add version to side nav * add pg 16 admonitions * ignore docs folder in charm workflows * sync misc. pages with k8s * Minor README update with new documentation link * add new section to CLI-helpers reference * pin commit for v16 tag on markdown lint workflow for added security * Update README.md * remove sphinx python dependency check workflow * Update index.md: add link to roles.md (#928) --------- Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Alex Lutay <1928266+taurus-forever@users.noreply.github.com> * [DPE-7511] Fix the auth username pattern (#941) * Fix auth username pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix another ocurrence of the pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add temp tablespace create * Temp tblspace outside of transaction * Reset role in test_pg_hba setup Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Detect when databases and their ACLs change Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix predefined catalog roles test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add missing autocommit Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove _hash suffix from variables names Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * [MISC] Fix timeouts in 14 to 16 merge (#959) * Handle PostgreSQLListUsersError * Try to trigger the pg_hba update on db requested * Try to hold db requested until pg_hba is up to date * Increase timeouts * Scale in parallel * Fix param passing * Increase timeout * Try to scale without ffwd * Try not to defer rel changed * Remove extra hook * Check if patroni is running before calling the health endpoint * Revert timeout * Pass the timeout param --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Dragomir Penev <6687393+dragomirp@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andreia <andreia.velasco@canonical.com> Co-authored-by: Vladimir Izmalkov <48120135+izmalk@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sinclert Pérez <sinclert.perez@canonical.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> Co-authored-by: swetha1654 <swetha.swaminathan@canonical.com> Co-authored-by: Shayan Patel <shayan.patel@canonical.com> Co-authored-by: Alex Lutay <1928266+taurus-forever@users.noreply.github.com>

* [MISC] Use latest/stable lxd (canonical#804) * Use latest stable lxd * Test tweaks * Test tweaks * Update canonical/data-platform-workflows action to v31.0.1 (canonical#805) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-6874] Poll all members in the cluster topology script (canonical#810) * Poll all members in the cluster topology script * Dual branch config * Unit tests and bugfixes * Add peers when starting the observer * Retry sync up checks * [DPE-6572] Add wal_keep_size config option (canonical#799) * Add wal_keep_size config option Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove parameter addition Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Reset durability_wal_keep_size value to PG default Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Create pull_request_template.md (canonical#814) * Create SECURITY.md (canonical#822) * Update README file's security section (canonical#827) * Refactor headings for syntax best practice * Update the Security section * Sync docs from Discourse (canonical#796) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * [MISC] Conditional checksum calculation (canonical#812) * Bump boto * Conditional checksum calculation * [DPE-6218] Static code analysis (canonical#828) * Create tiobe_scan.yaml * Remove push trigger * [MISC] Disable landscape subordinate test lxd (canonical#831) * Set series for ubuntu-advantage test and disable the landscape test * Revert to LTS LXD * Update charmcraft.yaml build tools (canonical#815) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Update snapped PostgreSQL (canonical#832) * [DPE-6345] LDAP I: Create access groups (canonical#823) * [DPE-6345] LDAP II: Include charm libs (canonical#824) * [DPE-6345] LDAP III: Define config and handlers (canonical#825) * [DPE-6345] LDAP IV: Define snap service (canonical#838) * [DPE-6345] LDAP V: Define mapping option (canonical#849) * [MISC] Disable network cut tests on arm (canonical#844) * Disable network cut tests on arm * Back to LXD 5 * [DPE-6815] disable pgaudit during extensions changes (canonical#842) * disable pgaudit during extensions changes * Bump libs * Lock file maintenance Python dependencies (main) (canonical#816) * Lock file maintenance Python dependencies * Fix linting --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> * Update dependency uv to v0.6.16 (canonical#847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-6664] Make username mandatory in set-password (canonical#846) * Make username mandatory * Second get password method * Default in get-password * Add conditional expose directive (canonical#853) * Lock file maintenance Python dependencies (canonical#854) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Mandatory scope for promote action (canonical#856) * Update charmcraft.yaml build tools (canonical#860) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Lock file maintenance Python dependencies (canonical#861) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Sync docs from Discourse (canonical#850) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * [MISC] Extend relation-user listing syntax (canonical#868) * Move _update_member_ip call to correctly remove Raft cluster member when network is cut Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix coverage Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Sync libs (canonical#884) * Update refresh tests to modify charm to ensure refresh off edge or stable * Fix lint warnings * Store temporary charms in /tmp for upgrade_from_stable tests * Use force-refresh-start instead of forcing refresh by updating versions * Remove runner password (canonical#913) * [DPE-6898] User->databases pg_hba rules (canonical#885) * Restrict each user to their allowed databases Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix sync users on replicas Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add default landscape user permission Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Increase sleep time in pg_hba test, fix user->database mapping for upgrade from stable and skip event trigger function code when not a superuser Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improve users list check Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix raft reinitialisation in tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Decrease the amount of API calls by one Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Check users list directly Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Tweak test fast interval Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improvements to avoid replica restart while syncing from primary Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix linting Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Handle same snap revision situation in upgrade tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Merge Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improvement to avoid replica restart while syncing from primary Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Run stop-continuous-writes action only once Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Increase sleep time in Juju spaces test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update charmcraft.yaml build tools (canonical#871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Remove JujuVersion warning in 14/edge (canonical#933) * Remove JujuVersion warning * Update libs * Refactor v14 documentation for Sphinx (canonical#919) * initial starter pack transfer * update conf.py * import processed discourse pages * fix internal references and some broken URLs * fix some style errors * organize navigation * remove h1 heading anchors * add images to repository * edit home page * update .readthedocs.yaml * remove docs/requirements.txt from .gitignore scope * fix incorrect paths * remove shell syntax from code blocks * remove juju 2 banners * fix dropdown formatting * fix and polish admonitions, collapsible, and misc formatting * remove v16 docs * remove reference to nonexistant page * Join all tutorial pages * rename how-to-guides to how-to * polish cloud deployment guides and rename leftover how-to-guide references * polish and sync how-to guides with k8s * remove discourse sync workflow * specify channel on all deploy commands * misc polishing, add version to side nav * add pg 16 admonitions * ignore docs folder in charm workflows * sync misc. pages with k8s * Minor README update with new documentation link * add new section to CLI-helpers reference * pin commit for v16 tag on markdown lint workflow for added security * Update README.md * remove sphinx python dependency check workflow * Update index.md: add link to roles.md (canonical#928) --------- Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Alex Lutay <1928266+taurus-forever@users.noreply.github.com> * [DPE-7511] Fix the auth username pattern (canonical#941) * Fix auth username pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix another ocurrence of the pattern Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add temp tablespace create * Temp tblspace outside of transaction * Reset role in test_pg_hba setup Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Detect when databases and their ACLs change Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix predefined catalog roles test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add missing autocommit Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove _hash suffix from variables names Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * [MISC] Fix timeouts in 14 to 16 merge (canonical#959) * Handle PostgreSQLListUsersError * Try to trigger the pg_hba update on db requested * Try to hold db requested until pg_hba is up to date * Increase timeouts * Scale in parallel * Fix param passing * Increase timeout * Try to scale without ffwd * Try not to defer rel changed * Remove extra hook * Check if patroni is running before calling the health endpoint * Revert timeout * Pass the timeout param --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Dragomir Penev <6687393+dragomirp@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andreia <andreia.velasco@canonical.com> Co-authored-by: Vladimir Izmalkov <48120135+izmalk@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sinclert Pérez <sinclert.perez@canonical.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> Co-authored-by: swetha1654 <swetha.swaminathan@canonical.com> Co-authored-by: Shayan Patel <shayan.patel@canonical.com> Co-authored-by: Alex Lutay <1928266+taurus-forever@users.noreply.github.com>

dragomirp added 4 commits June 10, 2025 04:02

Handle PostgreSQLListUsersError

4bf37c0

Try to trigger the pg_hba update on db requested

0f7eaa6

Try to hold db requested until pg_hba is up to date

9ca41e7

Increase timeouts

e1b0c1c

dragomirp added 10 commits June 10, 2025 20:21

Scale in parallel

07ff24a

Merge branch 'sync14to16-hashing' into sync14to16-timeout

9d438d0

Fix param passing

1b556d5

Increase timeout

aeb823f

Try to scale without ffwd

2fc2cc7

Try not to defer rel changed

ea5a823

Remove extra hook

7db1967

Merge branch 'sync14to16' into sync14to16-timeout

5d1cf58

Check if patroni is running before calling the health endpoint

709e9f3

Revert timeout

f8600d2

dragomirp commented Jun 12, 2025

View reviewed changes

tests/integration/ha_tests/test_async_replication.py

Copy link

Contributor Author

dragomirp Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scale the clusters together in parallel.

dragomirp changed the title ~~[MISC] timeouts~~ [MISC] Fix timeouts in 14 to 16 merge Jun 12, 2025

dragomirp added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Jun 12, 2025

dragomirp marked this pull request as ready for review June 12, 2025 08:54

dragomirp requested review from a team, taurus-forever and marceloneppel and removed request for a team June 12, 2025 08:54

taurus-forever approved these changes Jun 12, 2025

View reviewed changes

dragomirp added a commit that referenced this pull request Jun 12, 2025

Backport #959 to 14/edge

99582e5

Pass the timeout param

3c98a2c

marceloneppel approved these changes Jun 12, 2025

View reviewed changes

dragomirp merged commit 9504b88 into sync14to16 Jun 12, 2025
336 of 373 checks passed

dragomirp deleted the sync14to16-timeout branch June 12, 2025 15:35

dragomirp mentioned this pull request Jun 12, 2025

[MISC] Backport #959 to 14/edge #963

Merged

2 tasks

dragomirp added a commit that referenced this pull request Jun 13, 2025

Backport #959 to 14/edge (#963)

34b1b84

This was referenced Jun 17, 2025

[MISC] Hold database created hook for pg_hba changes canonical/postgresql-k8s-operator#1001

Merged

[MISC] Hold database created hook for pg_hba changes canonical/postgresql-k8s-operator#1002

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MISC] Fix timeouts in 14 to 16 merge #959

[MISC] Fix timeouts in 14 to 16 merge #959

Uh oh!

dragomirp commented Jun 10, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

taurus-forever Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

dragomirp Jun 12, 2025

Uh oh!

taurus-forever left a comment

Uh oh!

taurus-forever Jun 12, 2025

Uh oh!

marceloneppel left a comment

Uh oh!

Uh oh!

Uh oh!

[MISC] Fix timeouts in 14 to 16 merge #959

[MISC] Fix timeouts in 14 to 16 merge #959

Uh oh!

Conversation

dragomirp commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taurus-forever left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marceloneppel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dragomirp commented Jun 10, 2025 •

edited

Loading

codecov bot commented Jun 10, 2025 •

edited

Loading