Fix AWS bucket name and region #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
approved these changes
Mar 16, 2023
taurus-forever
approved these changes
Mar 16, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 13, 2024
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
Jul 14, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-arm64-postgresql-k8s-operator
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Jira issue: DPE-1504
Yesterday the AWS credentials were changed to the team credentials.
A test failed due to that because those credentials work only for the team bucket (that should be used instead the personal bucket): https://github.com/canonical/postgresql-k8s-operator/actions/runs/4436528202/jobs/7785176423
Solution
The bucket name and its region were changed in the test code (to use the team bucket).
Context
In the future we can probably move the bucket and region names to environment variables.
Testing
Used the existing tests to validate the change.
Release Notes
Fix AWS bucket name and region in integration test.