Skip to content

Parallelize tests #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Sep 5, 2022
Merged

Parallelize tests #34

merged 40 commits into from
Sep 5, 2022

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Sep 2, 2022 •
edited
Loading

Issue

  • Integration tests takes more than one hour to finish, even without, TLS, backups or more in depth high availability tests.

Solution

  • Separate integration tests in multiple tox environment and Github CI jobs.

Context

  • Some new markers were created to separate different tests.
  • Some existing high availability related tests were marked with the charm_tests marker and will be checked again later when more in depth high availability tests are implemented.

Testing

  • Tested manually and on Github CI to ensure all the existing tests are considered in the new tox environments and jobs.

Release Notes

  • Parallelize integration tests.

@marceloneppel
Change charm database user
fe8bd8b
@marceloneppel
Fix tests user
dd395f5
@marceloneppel
Add password rotation action
d325da6
@marceloneppel
Merge branch 'main' into password-rotation
4cf20fd
@marceloneppel
Merge branch 'main' into password-rotation
ca8f525
@marceloneppel
Rework secrets management
fc17a5e
@marceloneppel
Add unit tests
05b707e
@marceloneppel
Add constants
36640b2
@marceloneppel
Merge branch 'rework-secrets' into password-rotation
e345432
@marceloneppel
Update part of the code to correct actions
4735754
@marceloneppel
Merge branch 'main' into password-rotation
b8a3fd2
@marceloneppel
Implement password rotation
f7024e4
@marceloneppel
Improve messages
9c9b211
@marceloneppel
Improve get password test
4b7a534
@marceloneppel
Fix comment and remove unneeded else block
c92fdbc
@marceloneppel
Add set password unit test
0d7ea40
@marceloneppel
Improve unit test
71f86ac
@marceloneppel
Change helper function
a728a20
@marceloneppel
Add copyright notice
be497bc
@marceloneppel
Improve username retrieval
ef2bd31
@marceloneppel
Add initial code for password rotation test
8988aa3
@marceloneppel
Fix comment
7c75e45
@marceloneppel
Add test checks
34421e5
@marceloneppel
Small fix
4bc38b8
@marceloneppel
Add retry to helper function
14ec0f0
@marceloneppel
Fix lint problems
16dce63
@marceloneppel
Improve integration test
b6f2d8a
@marceloneppel
Add pytest mark
db8dbd8
@marceloneppel
Add separate jobs for different tests
8d47845
@marceloneppel
Add separate encironments for different tests
28a21ac
@marceloneppel
Define asyncio mode
f26dd32
@marceloneppel
Add pytest marks
0d8e795
@marceloneppel
Fix test name
88dd046
@marceloneppel
Remove duplicate job
4743b4d
@marceloneppel
Squashed commit of the following:
a512c84 
commit db8dbd8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Fri Aug 26 16:15:15 2022 -0300

    Add pytest mark

commit b6f2d8a
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 14:57:20 2022 -0300

    Improve integration test

commit 16dce63
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 13:50:42 2022 -0300

    Fix lint problems

commit 14ec0f0
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 13:48:51 2022 -0300

    Add retry to helper function

commit 4bc38b8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 11:56:41 2022 -0300

    Small fix

commit 34421e5
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 11:47:51 2022 -0300

    Add test checks

commit 7c75e45
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:08:04 2022 -0300

    Fix comment

commit 8988aa3
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:07:22 2022 -0300

    Add initial code for password rotation test

commit ef2bd31
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:06:50 2022 -0300

    Improve username retrieval

commit be497bc
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 08:31:03 2022 -0300

    Add copyright notice

commit a728a20
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 08:24:32 2022 -0300

    Change helper function

commit 71f86ac
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 16:34:58 2022 -0300

    Improve unit test

commit 0d7ea40
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 16:32:52 2022 -0300

    Add set password unit test

commit c92fdbc
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 15:42:47 2022 -0300

    Fix comment and remove unneeded else block

commit 4b7a534
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:59:35 2022 -0300

    Improve get password test

commit 9c9b211
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:54:54 2022 -0300

    Improve messages

commit f7024e4
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:46:00 2022 -0300

    Implement password rotation

commit b8a3fd2
Merge: 4735754 a336356
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 08:36:35 2022 -0300

    Merge branch 'main' into password-rotation

commit 4735754
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 16:22:37 2022 -0300

    Update part of the code to correct actions

commit e345432
Merge: ca8f525 36640b2
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 16:15:32 2022 -0300

    Merge branch 'rework-secrets' into password-rotation

commit 36640b2
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 11:44:53 2022 -0300

    Add constants

commit 05b707e
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 11:38:44 2022 -0300

    Add unit tests

commit fc17a5e
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 10:48:48 2022 -0300

    Rework secrets management

commit ca8f525
Merge: 4cf20fd 3e1ece8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Mon Aug 22 14:54:17 2022 -0300

    Merge branch 'main' into password-rotation

commit 4cf20fd
Merge: d325da6 62c636f
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 17 16:31:52 2022 -0300

    Merge branch 'main' into password-rotation

commit d325da6
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 17 16:27:28 2022 -0300

    Add password rotation action

commit dd395f5
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 16 10:57:19 2022 -0300

    Fix tests user

commit fe8bd8b
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 16 10:48:45 2022 -0300

    Change charm database user
@marceloneppel
Merge branch 'password-rotation' into parallelize-tests
b7cdedc
@marceloneppel
Improve pytest marks
cb10111
@marceloneppel
Register pytest markers
6a96797
@marceloneppel
Merge branch 'main' into parallelize-tests
36d365a
@marceloneppel
Fix pytest mark
c86888e
@marceloneppel marceloneppel marked this pull request as ready for review September 2, 2022 13:23
paulomach
paulomach approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marceloneppel marceloneppel merged commit 6a11b8a into main Sep 5, 2022
@marceloneppel marceloneppel deleted the parallelize-tests branch September 5, 2022 16:35
@marceloneppel marceloneppel mentioned this pull request Sep 5, 2022
Merged
github-actions bot added a commit to canonical/test-runners-2-github-x64-postgresql-k8s-operator that referenced this pull request May 20, 2024
@github-actions
Allure report canonical#34
04de907
github-actions bot added a commit to canonical/test-runners-2-is-x64-postgresql-k8s-operator that referenced this pull request May 20, 2024
@github-actions
Allure report canonical#34
66c41fb
BON4 pushed a commit to BON4/postgresql-k8s-operator that referenced this pull request May 20, 2024
@marceloneppel
Parallelize tests (canonical#34)
7e5bd7b 
* Change charm database user

* Fix tests user

* Add password rotation action

* Rework secrets management

* Add unit tests

* Add constants

* Update part of the code to correct actions

* Implement password rotation

* Improve messages

* Improve get password test

* Fix comment and remove unneeded else block

* Add set password unit test

* Improve unit test

* Change helper function

* Add copyright notice

* Improve username retrieval

* Add initial code for password rotation test

* Fix comment

* Add test checks

* Small fix

* Add retry to helper function

* Fix lint problems

* Improve integration test

* Add pytest mark

* Add separate jobs for different tests

* Add separate encironments for different tests

* Define asyncio mode

* Add pytest marks

* Fix test name

* Remove duplicate job

* Squashed commit of the following:

commit db8dbd8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Fri Aug 26 16:15:15 2022 -0300

    Add pytest mark

commit b6f2d8a
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 14:57:20 2022 -0300

    Improve integration test

commit 16dce63
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 13:50:42 2022 -0300

    Fix lint problems

commit 14ec0f0
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 13:48:51 2022 -0300

    Add retry to helper function

commit 4bc38b8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 11:56:41 2022 -0300

    Small fix

commit 34421e5
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 11:47:51 2022 -0300

    Add test checks

commit 7c75e45
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:08:04 2022 -0300

    Fix comment

commit 8988aa3
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:07:22 2022 -0300

    Add initial code for password rotation test

commit ef2bd31
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 09:06:50 2022 -0300

    Improve username retrieval

commit be497bc
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 08:31:03 2022 -0300

    Add copyright notice

commit a728a20
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Thu Aug 25 08:24:32 2022 -0300

    Change helper function

commit 71f86ac
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 16:34:58 2022 -0300

    Improve unit test

commit 0d7ea40
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 16:32:52 2022 -0300

    Add set password unit test

commit c92fdbc
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 15:42:47 2022 -0300

    Fix comment and remove unneeded else block

commit 4b7a534
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:59:35 2022 -0300

    Improve get password test

commit 9c9b211
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:54:54 2022 -0300

    Improve messages

commit f7024e4
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 13:46:00 2022 -0300

    Implement password rotation

commit b8a3fd2
Merge: 4735754 a336356
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 24 08:36:35 2022 -0300

    Merge branch 'main' into password-rotation

commit 4735754
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 16:22:37 2022 -0300

    Update part of the code to correct actions

commit e345432
Merge: ca8f525 36640b2
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 16:15:32 2022 -0300

    Merge branch 'rework-secrets' into password-rotation

commit 36640b2
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 11:44:53 2022 -0300

    Add constants

commit 05b707e
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 11:38:44 2022 -0300

    Add unit tests

commit fc17a5e
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 23 10:48:48 2022 -0300

    Rework secrets management

commit ca8f525
Merge: 4cf20fd 3e1ece8
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Mon Aug 22 14:54:17 2022 -0300

    Merge branch 'main' into password-rotation

commit 4cf20fd
Merge: d325da6 62c636f
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 17 16:31:52 2022 -0300

    Merge branch 'main' into password-rotation

commit d325da6
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Wed Aug 17 16:27:28 2022 -0300

    Add password rotation action

commit dd395f5
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 16 10:57:19 2022 -0300

    Fix tests user

commit fe8bd8b
Author: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Date:   Tue Aug 16 10:48:45 2022 -0300

    Change charm database user

* Improve pytest marks

* Register pytest markers

* Fix pytest mark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulomach paulomach paulomach approved these changes

@shayancanonical shayancanonical Awaiting requested review from shayancanonical

@zmraul zmraul Awaiting requested review from zmraul

@delgod delgod Awaiting requested review from delgod

@marcoppenheimer marcoppenheimer Awaiting requested review from marcoppenheimer

@Mehdi-Bendriss Mehdi-Bendriss Awaiting requested review from Mehdi-Bendriss

@MiaAltieri MiaAltieri Awaiting requested review from MiaAltieri

+1 more reviewer

@WRFitch WRFitch WRFitch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marceloneppel @paulomach @WRFitch