Skip to content

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Aug 27, 2022

Issue

  • Integration tests takes more than one hour to finish, even without, TLS, backups or more in depth high availability tests.

Solution

  • Separate integration tests in multiple tox environment and Github CI jobs.

Context

  • Some new markers were created to separate different tests.
  • Some existing high availability related tests were marked with the charm_tests marker and will be checked again later when more in depth high availability tests are implemented.
  • This is basically the same that was reviewed on Parallelize tests postgresql-k8s-operator#34, but for the VM charm now.

Testing

  • Tested manually and on Github CI to ensure all the existing tests are considered in the new tox environments and jobs.

Release Notes

  • Parallelize integration tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #26 (42a5b13) into password-rotation (62cc604) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           password-rotation      #26   +/-   ##
==================================================
  Coverage              61.83%   61.83%           
==================================================
  Files                      6        6           
  Lines                    765      765           
  Branches                 119      119           
==================================================
  Hits                     473      473           
  Misses                   264      264           
  Partials                  28       28           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marceloneppel marceloneppel changed the base branch from main to password-rotation August 27, 2022 13:09
Base automatically changed from password-rotation to main September 5, 2022 17:49
@marceloneppel marceloneppel marked this pull request as ready for review September 5, 2022 18:31
@marceloneppel marceloneppel requested a review from zmraul September 5, 2022 18:32
@marceloneppel marceloneppel merged commit 2ded6f4 into main Sep 8, 2022
@marceloneppel marceloneppel deleted the parallelize-tests branch September 8, 2022 13:18
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Change charm database user

* Fix unit tests

* Fix integration test call

* Fix user name in library

* Fix user

* Add default postgres user creation

* Change action name

* Rework secrets management

* Add password rotation logic

* Add user to the action parameters

* Add separate environments for different tests

* Add all dependencies

* Add pytest marks

* Fix action description

* Fix method docstring

* Fix pytest mark

* Fix pytest markers

* Register pytest markers
github-actions bot added a commit to canonical/test-runners-2-github-x64-postgresql-operator that referenced this pull request May 18, 2024
github-actions bot added a commit to canonical/test-runners-2-is-x64-postgresql-operator that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants