[DPE-5116] Add pgAudit #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 70.72% 70.81% +0.08%
==========================================
Files 11 11
Lines 2972 2981 +9
Branches 518 520 +2
==========================================
+ Hits 2102 2111 +9
Misses 758 758
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
requested review from
taurus-forever,
dragomirp and
lucasgameiroborges
taurus-forever
approved these changes
Sep 12, 2024
config.yaml
Outdated
| type: boolean | ||
| description: Enable timescaledb extension | ||
| plugin_audit_enable: | ||
| default: false |
There was a problem hiding this comment.
The same as VM, check default with Mohamed, please.
There was a problem hiding this comment.
Thanks for pointing that out, Alex! After syncing with Mohamed, I updated the plugin to enable it by default on 3243718.
dragomirp
approved these changes
Sep 16, 2024
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The pgAudit plugin/extension is available in the latest revision of the Charmed PostgreSQL rock, but not in this charm.
Solution
Expose pgAudit as another plugin/extension charm config option and enable it when requested by:
pgauditto the PostgreSQLshared_preload_librariesparameter.lib/charms/postgresql_k8s/v0/postgresql.py.Added new unit and integration tests.
Also, some adjustments were made in the plugin retrieval, which is used in the
config-changedanddatabase-requestedhook handlers.