[DPE-5248] Add pgAudit #612
Conversation
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 70.81% 70.89% +0.08%
==========================================
Files 12 12
Lines 3039 3048 +9
Branches 537 539 +2
==========================================
+ Hits 2152 2161 +9
Misses 771 771
Partials 116 116 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
requested review from
taurus-forever,
dragomirp and
lucasgameiroborges
config.yaml
Outdated
| type: boolean | ||
| description: Enable timescaledb extension | ||
| plugin_audit_enable: | ||
| default: false |
There was a problem hiding this comment.
JFYI, Audit plugin has been enabled on MySQL by default (for login actions only). Please check with @7annaba3l
|
Please update PR description: s/rock/snap/ |
Thanks, Alex! I updated the description. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Thanks for pointing that out, Alex! After syncing with Mohamed, I updated the plugin to enable it by default on 26ad2c0. |
tests/unit/test_charm.py
Outdated
| default: false | ||
| type: boolean | ||
| plugin_audit_enable: | ||
| default: false |
There was a problem hiding this comment.
We are testing possibility to enable pgaudit.
IMHO, we should keep default true, but test possibility of disabling it in the test below.
There was a problem hiding this comment.
Good catch! Fixed on e1d2916.
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Issue
The pgAudit plugin/extension is available in the latest revision of the Charmed PostgreSQL snap, but not in this charm.
Solution
Expose pgAudit as another plugin/extension charm config option and enable it when requested by:
pgauditto the PostgreSQLshared_preload_librariesparameter.lib/charms/postgresql_k8s/v0/postgresql.py.Added new unit and integration tests.
Also, some adjustments were made in the plugin retrieval, which is used in the
config-changedanddatabase-requestedhook handlers.This is a port of canonical/postgresql-k8s-operator#688.