Skip to content

Conversation

lucasgameiroborges
Copy link

@lucasgameiroborges lucasgameiroborges commented Oct 2, 2024

Issue

#698, #732

Solution

Set TLS flag inside the databag, using the existing interface. If TLS is set, then tls_ca is populated. See corresponding PR on relation-interfaces repo here: canonical/charm-relation-interfaces#185

Tested locally the way CS expected it to work (based on this un-merged PR commit: canonical/temporal-k8s-operator@a7e50f0) and confirmed it works as excepted (ie event.tls returns either True or False).

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (2a53fa3) to head (c88430f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/relations/postgresql_provider.py 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   71.65%   71.67%   +0.01%     
==========================================
  Files          11       12       +1     
  Lines        3031     3061      +30     
  Branches      464      468       +4     
==========================================
+ Hits         2172     2194      +22     
- Misses        753      758       +5     
- Partials      106      109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasgameiroborges lucasgameiroborges changed the title add tls flag to relation databag [DPE-5484] Add TLS flag to relation databag Oct 16, 2024
@lucasgameiroborges lucasgameiroborges marked this pull request as ready for review October 16, 2024 21:21
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucasgameiroborges lucasgameiroborges changed the title [DPE-5484] Add TLS flag to relation databag [DPE-5484] Add TLS flag + CA to relation databag Oct 18, 2024
@lucasgameiroborges lucasgameiroborges merged commit 01577b4 into main Oct 22, 2024
99 checks passed
@lucasgameiroborges lucasgameiroborges deleted the lucas/refactor-tls-flag branch October 22, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants