-
Notifications
You must be signed in to change notification settings - Fork 25
[DPE-5484] Add TLS flag + CA to relation databag #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 71.65% 71.67% +0.01%
==========================================
Files 11 12 +1
Lines 3031 3061 +30
Branches 464 468 +4
==========================================
+ Hits 2172 2194 +22
- Misses 753 758 +5
- Partials 106 109 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
#698, #732
Solution
Set TLS flag inside the databag, using the existing interface. If TLS is set, then
tls_ca
is populated. See corresponding PR on relation-interfaces repo here: canonical/charm-relation-interfaces#185Tested locally the way CS expected it to work (based on this un-merged PR commit: canonical/temporal-k8s-operator@a7e50f0) and confirmed it works as excepted (ie
event.tls
returns eitherTrue
orFalse
).