Updating ops framework and postgresql_tls charm lib #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
commented
Jan 23, 2023
| logger.error("An unknown certificate expiring.") | ||
| if ( | ||
| event.certificate_signing_request.strip() | ||
| != str(self.charm.get_secret(SCOPE, "csr")).strip() |
There was a problem hiding this comment.
Casting to string just in case, since the unit tests assume those to be None.
taurus-forever
approved these changes
Jan 24, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Updating ops framework and postgresql_tls charm lib * Lint and unit test fixes
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
Jun 17, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
Jun 17, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-arm64-postgresql-k8s-operator
that referenced
this pull request
Jun 18, 2024
github-actions bot
added a commit
to canonical/test-runners-2-azure-arm64-postgresql-k8s-operator
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
Testing
Release Notes