Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Jan 17, 2023

Issue

  • DPE-1081
  • Old lib juju is causing warnings in integration tests execution

Solution

  • update to latest version of libjuju for 2 (2.9.38.1)

Context

  • Only one test seemed to break
  • Also updating flake8 to the latest version expected to work
  • Also updating ops requirement to latest stable (1.5.4)

Testing

Release Notes

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #53 (d5df712) into main (c36b503) will increase coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   65.35%   66.19%   +0.83%     
==========================================
  Files           6        6              
  Lines         814      840      +26     
  Branches      115      121       +6     
==========================================
+ Hits          532      556      +24     
- Misses        258      260       +2     
  Partials       24       24              
Impacted Files Coverage Δ
src/constants.py 100.00% <0.00%> (ø)
src/charm.py 57.55% <0.00%> (+0.12%) ⬆️
src/cluster.py 71.08% <0.00%> (+3.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dragomirp dragomirp marked this pull request as ready for review January 17, 2023 15:43
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as tests are happy. Nice!

@dragomirp dragomirp changed the title Unpinning libjuju Updating libjuju to latest version for 2 Jan 19, 2023
@dragomirp dragomirp force-pushed the dpe-1081-libjuju-update branch from c8898f4 to d5df712 Compare January 20, 2023 15:53
@dragomirp dragomirp merged commit 28196bc into main Jan 23, 2023
@dragomirp dragomirp deleted the dpe-1081-libjuju-update branch January 23, 2023 11:14
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Unpinning libjuju

* Update pinned flake8 version

* Test tweak

* Pinning juju 2.9.38.1

* Tweaking CSR check
github-actions bot added a commit to canonical/test-runners-2-github-x64-postgresql-operator that referenced this pull request May 25, 2024
github-actions bot added a commit to canonical/test-runners-2-is-x64-postgresql-operator that referenced this pull request May 25, 2024
github-actions bot added a commit to canonical/test-runners-2-azure-arm64-postgresql-operator that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants