[DPE-6679] PostgreSQL Config Improvement #867

Pepsiqqq · 2025-02-19T16:06:41Z

Added all missing parameters from PostgreSQL config analysis (Added params 25.05):
https://docs.google.com/spreadsheets/d/1CbJMmSSP5eyu08y5vM8RNGrjiSxOLsa7RelwwUsi-vg/edit?pli=1&gid=815242942#gid=815242942

Were not added:

client_encoding: Session only parameter that can't be set by Patroni. Source
transaction_deferrable: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source
transaction_isolation: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source
transaction_read_only: This parameter cannot be set in the configuration file, or from any source other than live SQL. Source

Notice:

old_snapshot_threshold: Will be deleted in 17 version. Source
default_table_access_method: Added dynamic validation.

Also sorted config to improve readability.

# Conflicts: # config.yaml # src/config.py # tests/integration/test_config.py

Pepsiqqq · 2025-02-19T16:07:09Z

Will add DPE ticket later

# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py

marceloneppel

Thanks for the great work, Danylo!

I saw that some config options are missing, probably because their names are so similar to others that you added.

config.yaml

codecov · 2025-02-25T02:38:05Z

Codecov Report

Attention: Patch coverage is 75.23810% with 104 lines in your changes missing coverage. Please review.

Project coverage is 75.01%. Comparing base (ebf4756) to head (3997e3a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/config.py	75.59%	51 Missing and 51 partials ⚠️
src/charm.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   75.21%   75.01%   -0.20%     
==========================================
  Files          12       12              
  Lines        3187     3570     +383     
  Branches      477      528      +51     
==========================================
+ Hits         2397     2678     +281     
- Misses        643      695      +52     
- Partials      147      197      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py

dragomirp · 2025-03-07T17:03:26Z

Hi, @Pepsiqqq, please sync with main, the latest commit should skip the backup tests when no credentials are available.

* try using pg 16 rock * try fix integration tests * remove argument on helper * more fixes * fix test issues * REVERT LATER: Adapt build_charm function * remove base=CHARM_BASE from deploy * remove juju 2.9 tests * grat permissions to public schema * fix linting and unit test * try refactor the permissions change * Update dependency uv to v0.5.27 (#847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * grant public access to public schemas * [DPE-6053] Fix ports (#846) * Fix ports Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused import Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused charm library and fix unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix identation Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Bump libs * Conditional set_ports logic * Unit test * Don't expect juju managed resources --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * mark smoke test as unstable * test release charm to 16/edge * fix test release workflow * fix typo * Sync docs from Discourse (#801) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update dependency uv to v0.5.29 (#848) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Define charm utility properties (#842) * Update data-platform-workflows to v29.1.0 (#849) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * revert metadata.yaml * nits * Use `charmcraft test` & concierge (#852) * [MISC] Split topology script (#853) * Update charmcraft.yaml build tools (#851) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency uv to v0.5.31 (#858) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update canonical/data-platform-workflows action to v30 (#859) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use _promote_charm.yaml (#860) Use `charmcraft promote` and auto-generate release notes * Update dependency cryptography to v44.0.1 [SECURITY] (#855) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Sync docs from Discourse (#854) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update data-platform-workflows to v30.0.2 (#863) * Update canonical/has-signed-canonical-cla action to v2 (#865) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-5827] Set all nodes to synchronous replicas (#784) * Update patroni configuration * Update test assertion * Copy update_synchronous_node_count from VM * Add unit test * Set sync node count during upgrade * Fix tls test * Switchover primary * Add different helper to get leader * Add config boilerplate * Use config value when setting sync node count * Escape tuple * Add policy values * Add integration test * Fix casting * Fix test * Update to spec * Bump retry timout * Switch to planned units * Fix generator * Update conf description * Spread task * Pass the charm * [DPE-6484] Add scope to promote to primary (#850) * Promote unit action * Tweaks for failing REST calls * VM parity * [MISC] Enable RBAC in tests (#861) * Enable RBAC * Bump cosl * Add trust * Bump libs * [MISC] Define charm constants (#862) * Lock file maintenance Python dependencies (#835) * Lock file maintenance Python dependencies * Backoff boto3 1.36 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> * Update canonical/data-platform-workflows action to v30.1.3 (#856) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update charmcraft.yaml build tools (#868) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Handle missing stanza output (#866) * Update ghcr.io/canonical/charmed-postgresql:14.15-22.04_edge Docker digest to 71d49b6 (#870) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Disable storage test on arm (#872) * Disable storage test on Arm * Bump libs * Correct import path * Update charmcraft.yaml build tools (#871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Add degraded status to primary message (#874) * Add degraded status on to primary message * Use const running tests * [MISC] Sanitize PostgreSQL extra-user-roles arg (#876) * [MISC] Fix PostgreSQL lib function signature (#879) * [MISC] Skip backup tests without creds (#884) * Bump libs * Skip backups tests if no creds are set * Check that the cloud config is set to a value * Typo * Update tests/integration/conftest.py Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> * Switch all checks to gets * Typo --------- Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> * [DPE-6679] PostgreSQL Config Improvement (#867) * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * Update dependency jinja2 to v3.1.6 [SECURITY] (#882) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update canonical/data-platform-workflows action to v30.2.0 (#887) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Reduce required approvals on Renovate pull requests by 1 (#880) * Update dependency uv to v0.6.5 (#878) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Don't run juju2 and legacy tests * Use correct charm * Dual branch config * Remove 14 specific tests * Remove eer data secrets * Skip upgrade from stable * Upgrade on Noble * Build and deploy noble * Linting * Disable pgaudit during tests * Linting * Use common deploy for smoke test * Tweaks * Remove legacy rels * Tweak tests * Cleanup markers * Deploy without pgaudit in plugin tests * Update ghcr.io/canonical/charmed-postgresql Docker tag to v14.17 (#877) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Correct remove relation * Bump rock * Remove check for port forwarding --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Lucas Gameiro Borges <lucas.borges@canonical.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <6687393+dragomirp@users.noreply.github.com> Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sinclert Pérez <sinclert.perez@canonical.com> Co-authored-by: lucas.gameiro-borges <lucas.gameiro-borges@student-cs.fr> Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> Co-authored-by: Danylo Bereznenko <pepsiqqfanta@gmail.com>

* Update dependency uv to v0.5.27 (#847) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-6053] Fix ports (#846) * Fix ports Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused import Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Remove unused charm library and fix unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix identation Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Bump libs * Conditional set_ports logic * Unit test * Don't expect juju managed resources --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Sync docs from Discourse (#801) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update dependency uv to v0.5.29 (#848) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Define charm utility properties (#842) * Update data-platform-workflows to v29.1.0 (#849) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use `charmcraft test` & concierge (#852) * [MISC] Split topology script (#853) * Update charmcraft.yaml build tools (#851) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency uv to v0.5.31 (#858) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update canonical/data-platform-workflows action to v30 (#859) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use _promote_charm.yaml (#860) Use `charmcraft promote` and auto-generate release notes * Update dependency cryptography to v44.0.1 [SECURITY] (#855) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Sync docs from Discourse (#854) Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update data-platform-workflows to v30.0.2 (#863) * Update canonical/has-signed-canonical-cla action to v2 (#865) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [DPE-5827] Set all nodes to synchronous replicas (#784) * Update patroni configuration * Update test assertion * Copy update_synchronous_node_count from VM * Add unit test * Set sync node count during upgrade * Fix tls test * Switchover primary * Add different helper to get leader * Add config boilerplate * Use config value when setting sync node count * Escape tuple * Add policy values * Add integration test * Fix casting * Fix test * Update to spec * Bump retry timout * Switch to planned units * Fix generator * Update conf description * Spread task * Pass the charm * [DPE-6484] Add scope to promote to primary (#850) * Promote unit action * Tweaks for failing REST calls * VM parity * [MISC] Enable RBAC in tests (#861) * Enable RBAC * Bump cosl * Add trust * Bump libs * [MISC] Define charm constants (#862) * Lock file maintenance Python dependencies (#835) * Lock file maintenance Python dependencies * Backoff boto3 1.36 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dragomir Penev <dragomir.penev@canonical.com> * Update canonical/data-platform-workflows action to v30.1.3 (#856) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update charmcraft.yaml build tools (#868) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Handle missing stanza output (#866) * Update ghcr.io/canonical/charmed-postgresql:14.15-22.04_edge Docker digest to 71d49b6 (#870) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Disable storage test on arm (#872) * Disable storage test on Arm * Bump libs * Correct import path * Update charmcraft.yaml build tools (#871) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [MISC] Add degraded status to primary message (#874) * Add degraded status on to primary message * Use const running tests * [MISC] Sanitize PostgreSQL extra-user-roles arg (#876) * [MISC] Fix PostgreSQL lib function signature (#879) * [MISC] Skip backup tests without creds (#884) * Bump libs * Skip backups tests if no creds are set * Check that the cloud config is set to a value * Typo * Update tests/integration/conftest.py Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> * Switch all checks to gets * Typo --------- Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> * [DPE-6679] PostgreSQL Config Improvement (#867) * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * config improvement * Update dependency jinja2 to v3.1.6 [SECURITY] (#882) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update canonical/data-platform-workflows action to v30.2.0 (#887) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Reduce required approvals on Renovate pull requests by 1 (#880) * Update dependency uv to v0.6.5 (#878) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update ghcr.io/canonical/charmed-postgresql Docker tag to v14.17 (#877) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency uv to v0.6.7 (#890) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update canonical/data-platform-workflows action to v31 (#891) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Try the new timescale * Check PR on */edge * Enable cache, disable pgaudit * Use the right base * Arm tests --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sinclert Pérez <sinclert.perez@canonical.com> Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com> Co-authored-by: Danylo Bereznenko <pepsiqqfanta@gmail.com>

Pepsiqqq added 10 commits February 17, 2025 14:53

config improvement

e9e8df9

config improvement

18a356d

config improvement

e1cfb77

config improvement

a1e1131

config improvement

f9c0738

config improvement

38ea3da

config improvement

1181b4d

config improvement

51ebdbb

Merge branch 'main' into config

5501095

# Conflicts: # config.yaml # src/config.py # tests/integration/test_config.py

config improvement

3941894

dragomirp requested review from a team, dragomirp, marceloneppel and taurus-forever and removed request for a team February 19, 2025 16:08

Pepsiqqq added 2 commits February 19, 2025 18:13

config improvement

76b7852

Merge branch 'main' into config

f4d53d1

# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py

Pepsiqqq mentioned this pull request Feb 20, 2025

[DPE-6678] PostgreSQL Config Improvement canonical/postgresql-operator#778

Merged

dragomirp added the enhancement New feature, UI change, or workload upgrade label Feb 21, 2025

Pepsiqqq changed the title ~~PostgreSQL Config Improvement~~ [DPE-6679] PostgreSQL Config Improvement Feb 24, 2025

taurus-forever requested a review from 7annaba3l February 24, 2025 11:20

marceloneppel requested changes Feb 25, 2025

View reviewed changes

config.yaml Show resolved Hide resolved

marceloneppel approved these changes Feb 25, 2025

View reviewed changes

Merge branch 'main' into config

b01ef86

# Conflicts: # lib/charms/postgresql_k8s/v0/postgresql.py

Merge branch 'canonical:main' into config

3997e3a

dragomirp approved these changes Mar 10, 2025

View reviewed changes

taurus-forever approved these changes Mar 10, 2025

View reviewed changes

dragomirp merged commit c71262d into canonical:main Mar 10, 2025
94 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DPE-6679] PostgreSQL Config Improvement #867

[DPE-6679] PostgreSQL Config Improvement #867

Uh oh!

Pepsiqqq commented Feb 19, 2025

Uh oh!

Pepsiqqq commented Feb 19, 2025

Uh oh!

marceloneppel left a comment

Uh oh!

Uh oh!

codecov bot commented Feb 25, 2025 •

edited

Loading

Uh oh!

dragomirp commented Mar 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[DPE-6679] PostgreSQL Config Improvement #867

[DPE-6679] PostgreSQL Config Improvement #867

Uh oh!

Conversation

Pepsiqqq commented Feb 19, 2025

Uh oh!

Pepsiqqq commented Feb 19, 2025

Uh oh!

marceloneppel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dragomirp commented Mar 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 25, 2025 •

edited

Loading