[DPE-6815] disable pgaudit during extensions changes #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-6815-disable-pgaudit
branch
from
5bad788 to
0eeb5a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #923 +/- ##
========================================
Coverage 74.50% 74.50%
========================================
Files 12 12
Lines 3550 3550
Branches 508 508
========================================
Hits 2645 2645
Misses 708 708
Partials 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-6815-disable-pgaudit
branch
from
b6f91bd to
f5277f0
Compare
dragomirp
force-pushed
the
dpe-6815-disable-pgaudit
branch
from
1fd2dd4 to
b93828f
Compare
dragomirp
force-pushed
the
dpe-6815-disable-pgaudit
branch
from
ec98c4c to
d647a2e
Compare
This reverts commit d647a2e.
dragomirp
added
bug
dragomirp
commented
Apr 17, 2025
| for extension, enable in extensions.items(): | ||
| ordered_extensions[extension] = enable | ||
|
|
||
| self._configure_pgaudit(False) |
There was a problem hiding this comment.
Disable pgaudit before processing the plugins and databases. It should get reenabled on line 451.
2 tasks
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
shayancanonical
and removed request for
a team
shayancanonical
approved these changes
Apr 17, 2025
marceloneppel
approved these changes
Apr 17, 2025
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist