Skip to content

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Apr 16, 2025

  • Disable pgaudit during plugin initialisation
  • Update charm libraries

Port of canonical/postgresql-k8s-operator#923

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp dragomirp added the bug Something isn't working as expected label Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (9a41525) to head (16c9376).
Report is 2 commits behind head on 16/edge.

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge     #840   +/-   ##
========================================
  Coverage    72.14%   72.14%           
========================================
  Files           14       14           
  Lines         3701     3701           
  Branches       548      548           
========================================
  Hits          2670     2670           
  Misses         854      854           
  Partials       177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dragomirp dragomirp force-pushed the dpe-6815-disable-pgaudit branch from 62ee227 to d116588 Compare April 16, 2025 20:39
@dragomirp dragomirp marked this pull request as ready for review April 22, 2025 10:53
@dragomirp dragomirp requested review from a team, taurus-forever and marceloneppel and removed request for a team April 22, 2025 10:53
Comment on lines +438 to +439
self._configure_pgaudit(False)

Copy link
Contributor Author

@dragomirp dragomirp Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual change. Pgaudit should be reenabled on line 451 if configured.

@dragomirp dragomirp merged commit 1d83dda into 16/edge Apr 22, 2025
63 checks passed
@dragomirp dragomirp deleted the dpe-6815-disable-pgaudit branch April 22, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected Libraries: OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants