[DPE-8337] Disable Patroni config to prevent possible data loss #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from PG14 #1173
Issue
In case of the split brain OR old primary cluster re-joining,
the special Patroni config options did re-silver the data,
potentially loosing the data on old-Primary unit (
as it cannot re-join current Primary due to timelines divergence).
The follow-up charm improvements are necessary to simplify re-init for user,
but for now let's disable dangerous Patroni options added in 29b8098.
Solution
Disable Patroni config options explicitly:
remove_data_directory_on_rewind_failure
andremove_data_directory_on_diverged_timelines
.They are disabled by default in Patroni.
Fixes 1153
Checklist