Skip to content

[DPE-8337] Disable Patroni config to prevent possible data loss #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

[DPE-8337] Disable Patroni config to prevent possible data loss #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07f25d7
DPE-8337 Disable Patroni config to prevent possible dataloose
taurus-forever Sep 22, 2025
48ca085
Merge branch '16/edge' into alutay/disable_pg_rewind_pg16
dragomirp Sep 23, 2025
cff82b3
Force config change for upgrade
dragomirp Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,13 @@ def bulk_update_parameters_controller_by_patroni(self, parameters: dict[str, Any
r = requests.patch(
f"{self._patroni_url}/config",
verify=self.verify,
json={"postgresql": {"parameters": parameters}},
json={
"postgresql": {
"remove_data_directory_on_rewind_failure": False,
"remove_data_directory_on_diverged_timelines": False,
"parameters": parameters,
}
},
auth=self._patroni_auth,
timeout=PATRONI_TIMEOUT,
)
Expand Down
4 changes: 2 additions & 2 deletions templates/patroni.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ bootstrap:
synchronous_node_count: {{ synchronous_node_count }}
postgresql:
use_pg_rewind: true
remove_data_directory_on_rewind_failure: true
remove_data_directory_on_diverged_timelines: true
remove_data_directory_on_rewind_failure: false
remove_data_directory_on_diverged_timelines: false
parameters:
synchronous_standby_names: "*"
{%- if enable_pgbackrest_archiving %}
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/test_charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ async def test_settings_are_correct(ops_test: OpsTest, unit_id: int):

# Validate each configuration related to Patroni
assert settings["postgresql"]["use_pg_rewind"] is True
assert settings["postgresql"]["remove_data_directory_on_rewind_failure"] is True
assert settings["postgresql"]["remove_data_directory_on_diverged_timelines"] is True
assert settings["postgresql"]["remove_data_directory_on_rewind_failure"] is False
assert settings["postgresql"]["remove_data_directory_on_diverged_timelines"] is False
assert settings["loop_wait"] == 10
assert settings["retry_timeout"] == 10
assert settings["maximum_lag_on_failover"] == 1048576
Expand Down