[MISC] Conditionally create the legacy interface to support Juju 4 #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
commented
Jul 9, 2025
| self, | ||
| event: pgsql.DatabaseRelationJoinedEvent, # type: ignore | ||
| ) -> None: | ||
| def _on_database_relation_joined(self, event) -> None: |
There was a problem hiding this comment.
Type definition, not strictly necessary.
dragomirp
commented
Jul 9, 2025
| self.db.on.database_relation_joined, self._on_database_relation_joined | ||
| ) | ||
| if self.model.juju_version.major < 4: | ||
| pgsql = ops.lib.use("pgsql", 1, "postgresql-charmers@lists.launchpad.net") |
There was a problem hiding this comment.
Moved inside the if in case the lib loader also causes issues.
dragomirp
requested review from
a team,
taurus-forever and
marceloneppel
and removed request for
a team
taurus-forever
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
LGTM, Tnx!
@anvial please test from your side.
P.S. @dragomirp should we block the charm if user request psql relation on Juju 4+ ?
No need IMHO. The interface is only used here to block the provider if roles and extensions are requested. It is not a functional integration in the first place. |
marceloneppel
approved these changes
Jul 9, 2025
|
There seems to be an issue with the restart test on VM. Disabling for now to unblock Juju 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #367