[MISC] Blocked status when database relation is not initialised #369
Conversation
dragomirp
force-pushed
the
waiting-status
branch
from
3737228 to
6507244
Compare
dragomirp
force-pushed
the
waiting-status
branch
from
6507244 to
bb8f0fd
Compare
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
src/charm.py
Outdated
| """Only sets an Active status.""" | ||
| self.unit.status = ActiveStatus() | ||
| """Sets initial Waiting status and checks if writes should be restarted.""" | ||
| self.unit.status = WaitingStatus() |
There was a problem hiding this comment.
We should most probably replace it with Blocked status, as it needs a relation to be formed (based on the status's meaning from the figure from https://documentation.ubuntu.com/juju/3.6/reference/status/#application-status).
There was a problem hiding this comment.
Blocked status may require tweaks in downstream CIs, IIRC libjuju's wait for idle errors out by default on blocked status.
| client = Client(namespace=ops_test.model.info.name) | ||
| client.delete(Pod, name=f"{TEST_APP_NAME}-0") | ||
| else: | ||
| pytest.skip("Unstable LXC restart test") |
There was a problem hiding this comment.
Can you please mention this problem in PR description at least.
BTW. what is unstable in LXD restart?
There was a problem hiding this comment.
This removes the unstable marker for LXD added in #368 (comment). The test passes now, so it's no longer to be skipped.
src/charm.py
Outdated
| """Only sets an Active status.""" | ||
| self.unit.status = ActiveStatus() | ||
| """Sets initial Waiting status and checks if writes should be restarted.""" | ||
| self.unit.status = BlockedStatus("Waiting for integration") |
There was a problem hiding this comment.
Thank you for reacting on Marcelo comment about Waiting=>Blocked switch, but the Juju status message is still confusingly saying waiting, which may confuse end-users.
Let's hint them to act:
Integrate with the database provider (e.g. data-integrator)
or
No database relation available (e.g. sysbench charm)
There was a problem hiding this comment.
Changed message to No database integration available.
dragomirp
force-pushed
the
waiting-status
branch
from
448aef4 to
6963c85
Compare
dragomirp
changed the title
3 participants
Uh oh!
There was an error while loading. Please reload this page.