Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround for LXD sometimes failing to refresh #85

Closed
wants to merge 1 commit into from

Conversation

ghislainbourgeois
Copy link
Contributor

Stop LXD if it will be refreshed to workaround an issue happening often in CI where LXD fails to refresh because of a missing socket file.

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner November 20, 2024 14:07
Comment on lines +29 to +32

# Workaround for lxd sometimes failing to refresh
sudo snap info lxd | grep "tracking": | awk '{print $2}' | grep "5.21/stable" || sudo snap stop lxd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue in concierge to inform Jon that we have to go through this workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon is already aware, I looked through the code and implementing this workaround is not straightforward, otherwise I would have put the workaround there.

I will open an issue also on concierge to track it. At the end of the day however, the issue is with the LXD snap, and this workaround needs to be in place in whatever CI implementation we use (I think it is already included in actions-operator).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a relatively clean way of implementing the workaround on concierge. Here are the issue and PR:

jnsgruk/concierge#20
jnsgruk/concierge#21

If they get merged soon, we could drop this PR. Otherwise, we can merge this to unblock CI and revert it once it is not necessary.

@ghislainbourgeois
Copy link
Contributor Author

Switching to draft as this is currently being tested here: canonical/sdcore-amf-k8s-operator#463

@ghislainbourgeois ghislainbourgeois marked this pull request as draft November 20, 2024 14:15
@ghislainbourgeois ghislainbourgeois marked this pull request as ready for review November 20, 2024 15:09
@ghislainbourgeois
Copy link
Contributor Author

concierge 0.9.3 will be coming out soon with that workaround integrated. Closing this PR.

@ghislainbourgeois ghislainbourgeois deleted the fix-workaround-lxd-issue branch November 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants