Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround for LXD sometimes failing to refresh #85

Closed
wants to merge 1 commit into from
Closed

fix: Workaround for LXD sometimes failing to refresh #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/integration-test-machine.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ jobs:
- name: Setup operator environment
run: |
sudo snap install concierge --classic

# Workaround for lxd sometimes failing to refresh
sudo snap info lxd | grep "tracking": | awk '{print $2}' | grep "5.21/stable" || sudo snap stop lxd

Comment on lines +29 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue in concierge to inform Jon that we have to go through this workaround?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon is already aware, I looked through the code and implementing this workaround is not straightforward, otherwise I would have put the workaround there.

I will open an issue also on concierge to track it. At the end of the day however, the issue is with the LXD snap, and this workaround needs to be in place in whatever CI implementation we use (I think it is already included in actions-operator).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a relatively clean way of implementing the workaround on concierge. Here are the issue and PR:

jnsgruk/concierge#20
jnsgruk/concierge#21

If they get merged soon, we could drop this PR. Otherwise, we can merge this to unblock CI and revert it once it is not necessary.

sudo concierge prepare -p machine --juju-channel "3.5/stable" --lxd-channel "5.21/stable" --extra-snaps astral-uv/latest/stable
uv tool install tox --with tox-uv

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/integration-test-with-multus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ jobs:
- name: Setup operator environment
run: |
sudo snap install concierge --classic

# Workaround for lxd sometimes failing to refresh
sudo snap info lxd | grep "tracking": | awk '{print $2}' | grep "5.21/stable" || sudo snap stop lxd

sudo concierge prepare -p microk8s --microk8s-channel "1.31-strict/stable" --juju-channel "3.5/stable" --lxd-channel "5.21/stable" --extra-snaps astral-uv/latest/stable
sudo microk8s enable hostpath-storage dns metallb:10.0.0.2-10.0.0.10
uv tool install tox --with tox-uv
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/integration-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ jobs:
- name: Setup operator environment
run: |
sudo snap install concierge --classic

# Workaround for lxd sometimes failing to refresh
sudo snap info lxd | grep "tracking": | awk '{print $2}' | grep "5.21/stable" || sudo snap stop lxd

sudo concierge prepare -p microk8s --microk8s-channel "1.31-strict/stable" --juju-channel "3.5/stable" --lxd-channel "5.21/stable" --extra-snaps astral-uv/latest/stable
uv tool install tox --with tox-uv

Expand Down