Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/7.5 gpg multi keys #4241

Closed
wants to merge 3 commits into from
Closed

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Jun 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

tigarmo and others added 3 commits June 27, 2023 17:16
The new version supports asset files that contain more than one key
(for whatever reason). This is more in line with the behavior done by
the previous implementation (via apt-key).

Closes #4224
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #4241 (b8f75f5) into hotfix/7.5 (aa3d5d6) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4241   +/-   ##
===========================================
  Coverage       94.85%   94.85%           
===========================================
  Files             649      649           
  Lines           54379    54379           
===========================================
  Hits            51580    51580           
  Misses           2799     2799           
Impacted Files Coverage Δ
setup.py 100.00% <ø> (ø)
snapcraft_legacy/plugins/v1/catkin.py 93.99% <ø> (ø)
snapcraft_legacy/plugins/v1/colcon.py 98.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens
Copy link
Collaborator

code spell is having a field day

lint-codespell: commands[0]> codespell --toml /home/runner/work/snapcraft/snapcraft/pyproject.toml
Used config files:
    1: setup.cfg
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:5: fpr ==> for, far, fps
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:9: fpr ==> for, far, fps
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:12: fpr ==> for, far, fps
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:15: fpr ==> for, far, fps
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:17: fpr ==> for, far, fps
./tests/spread/core22/package-repositories/test-multi-keys/snap/keys/9E61EF26.asc:20: fpr ==> for, far, fps
lint-codespell: exit 65 (1.21 seconds) /home/runner/work/snapcraft/snapcraft> codespell --toml /home/runner/work/snapcraft/snapcraft/pyproject.toml pid=19271
lint-yaml: skip building and installing the package
lint-yaml: freeze> python -m pip freeze --all
lint-codespell: FAIL ✖ in 1.69 seconds

@tigarmo
Copy link
Contributor Author

tigarmo commented Jul 4, 2023

Merged by #4253

@tigarmo tigarmo closed this Jul 4, 2023
@tigarmo tigarmo deleted the hotfix/7.5-gpg-multi-keys branch July 4, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants