Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-repositories: update craft-archives to support multi-keys. #4253

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Jul 3, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

The new version supports asset files that contain more than one key
(for whatever reason). This is more in line with the behavior done by
the previous implementation (via apt-key).

Closes #4224
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #4253 (a311e7c) into hotfix/7.5 (aa3d5d6) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4253   +/-   ##
===========================================
  Coverage       94.85%   94.85%           
===========================================
  Files             649      649           
  Lines           54379    54379           
===========================================
  Hits            51580    51580           
  Misses           2799     2799           
Impacted Files Coverage Δ
setup.py 100.00% <ø> (ø)
snapcraft_legacy/plugins/v1/catkin.py 93.99% <ø> (ø)
snapcraft_legacy/plugins/v1/colcon.py 98.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens
Copy link
Collaborator

sergiusens commented Jul 3, 2023

I create #4256 to track this spread error we are seeing

@sergiusens sergiusens merged commit b6bd029 into hotfix/7.5 Jul 3, 2023
@tigarmo tigarmo mentioned this pull request Jul 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants