Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: workaround for pyright bug #4243

Merged
merged 1 commit into from
Jun 29, 2023
Merged

type: workaround for pyright bug #4243

merged 1 commit into from
Jun 29, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Cherry-pick #3423 into hotfix/7.5

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #4243 (2190394) into hotfix/7.5 (4ce377c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           hotfix/7.5    #4243      +/-   ##
==============================================
- Coverage       94.85%   94.85%   -0.01%     
==============================================
  Files             648      648              
  Lines           54353    54355       +2     
==============================================
+ Hits            51555    51556       +1     
- Misses           2798     2799       +1     
Impacted Files Coverage Δ
snapcraft/commands/names.py 90.00% <100.00%> (+0.16%) ⬆️
snapcraft/commands/status.py 92.92% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens enabled auto-merge (rebase) June 29, 2023 22:54
@sergiusens sergiusens disabled auto-merge June 29, 2023 22:54
@sergiusens sergiusens merged commit b3dee09 into hotfix/7.5 Jun 29, 2023
@sergiusens sergiusens deleted the lint-pyright branch June 29, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants